Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add volume fraction profile to Correlation Function analysis (Trac #785) #891

Open
smk78 opened this issue Mar 30, 2019 · 8 comments
Open
Assignees
Labels
Corfunc Perspective Concerns Correlation Function Perspective Enhancement Feature requests and/or general improvements Inversion Perspective Concerns inversion perspective Major Big change in the code or important change in behaviour
Milestone

Comments

@smk78
Copy link
Contributor

smk78 commented Mar 30, 2019

The new correlation function analysis implemented post-4.0 has a radio button for the option to perform a Hilbert transform to generate a volume fraction profile for adsorbed layers.

The code to perform this currently exists but in Fortran. It needs porting to Python and then integrating with the corfunc perspective.

Migrated from http://trac.sasview.org/ticket/785

{
    "status": "new",
    "changetime": "2017-10-26T11:05:19",
    "_ts": "2017-10-26 11:05:19.611585+00:00",
    "description": "The new correlation function analysis implemented post-4.0 has a radio button for the option to perform a Hilbert transform to generate a volume fraction profile for adsorbed layers.\n\nThe code to perform this currently exists but in Fortran. It needs porting to Python and then integrating with the corfunc perspective.",
    "reporter": "smk78",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView GUI Enhancements",
    "time": "2016-10-14T15:46:05",
    "component": "SasView",
    "summary": "Add volume fraction profile to Correlation Function analysis",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.3.0",
    "owner": "smk78",
    "type": "enhancement"
}
@smk78 smk78 added this to the SasView 4.3.0 milestone Mar 30, 2019
@smk78 smk78 self-assigned this Mar 30, 2019
@smk78 smk78 added Enhancement Feature requests and/or general improvements Incomplete Migration Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2017/10/23 16:33:48: butler commented:

Steve K. isn't this done now?

@butlerpd
Copy link
Member

Trac update at 2017/10/23 16:34:03: butler changed milestone from "SasView Next Release +1" to "SasView 4.2.0"

@smk78
Copy link
Contributor Author

smk78 commented Mar 30, 2019

Trac update at 2017/10/23 17:13:55: smk78 commented:

No. Not started. The quick option to getting it working though would be to bundle a Fortran compiler...

@butlerpd
Copy link
Member

Trac update at 2017/10/26 11:04:35:

  • butler changed _comment0 from "Ok ... but dont we have the Hilbert transform already for the SESANS code? anyway guess it won't be done for 4.2 s moving to 4.3 for now." to "1509015919611585"
  • butler commented:

Ok ... but dont we have the Hilbert transform already for the SESANS code? anyway guess it won't be done for 4.2 so moving to 4.3 for now.

  • butler changed milestone from "SasView 4.2.0" to "SasView 4.3.0"

@rprospero rprospero self-assigned this Jun 12, 2019
@butlerpd butlerpd modified the milestones: SasView 4.3.0, SasView 5.1.0 Apr 26, 2020
@butlerpd
Copy link
Member

Moving to 5.1

@smk78 smk78 added the Corfunc Perspective Concerns Correlation Function Perspective label Sep 15, 2020
@dehoni dehoni added the Inversion Perspective Concerns inversion perspective label Mar 18, 2022
@lucas-wilkins
Copy link
Contributor

@dehoni Is this the issue we discussed that isn't actually anything to do with corfunc?

@dehoni
Copy link
Contributor

dehoni commented Jun 24, 2022

@dehoni Is this the issue we discussed that isn't actually anything to do with corfunc?

We were discussing $\Gamma_1$ with the $cos(qr)$ transform (undocumented origin). I assume that it is just a "normal" 1D Fourier transform of a symmetric function. This might be relevant for lamellar system.
I questioned if there should not be rather a Bessel function J0 to transform the 2D, but radial symmetric scattering pattern on the detector. In a second thought, this should be called $\Gamma_2$. I have never ever seen someone using it, might be disturbing and only of academic value.
$\Gamma_3$ is then the transform with the spherical Bessel transform $sin(qr)/qr$ as it already exists and known by everyone in the soft and hard matter community.
The Hilbert transform seems to be still another biest. But the cited literature is hidden behind a paywall. @smk78 has surely more information on it...given that he is author on several of the papers.

@smk78
Copy link
Contributor Author

smk78 commented Jun 24, 2022

@smk78 does indeed know more about volume fraction profiles!

In the first instance, please see https://www.sasview.org/docs/_downloads/92ef44d1f703934655c43868021c297e/Fibre_Diffraction_Review_2005_13_19-22.pdf

The reason this is 'associated' with Corfunc is that the processing is very similar: take the experimental data, extrapolate it at both ends, and transform it. (In the original Corfunc implementation there was no extract parameters step). So the idea was there would just be a radio button to select the transform type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Corfunc Perspective Concerns Correlation Function Perspective Enhancement Feature requests and/or general improvements Inversion Perspective Concerns inversion perspective Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

5 participants