Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models with the same name in different directories will not be distinguished (Trac #787) #260

Open
pkienzle opened this issue Mar 30, 2019 · 3 comments

Comments

@pkienzle
Copy link
Contributor

The function generate.tag_source returns a unique string associated with the source code for the model. Use this rather than time stamps to determine if the model needs to be recompiled. Remove all the time stamp comparison code since it is complicated and error prone.

Precompiled models that are supplied with the windows installer will need to include the tag, which may complicate the installer. Are precompiled models needed given that !SasView ships with tinycc?

OpenCL kernels already use the tag for testing if a recompile is needed. It also check timestamps, so kernelcl.py should also be updated.

In practice, this issue will only be a problem for users that don't have OpenCL but are making their own versions of models with the same name as the builtin model, and still want to run the builtin model. Currently, the most recently changed source will win.

Migrated from http://trac.sasview.org/ticket/787

{
    "status": "assigned",
    "changetime": "2018-02-13T02:29:31",
    "_ts": "2018-02-13 02:29:31.442888+00:00",
    "description": "The function `generate.tag_source` returns a unique string associated with the source code for the model.  Use this rather than time stamps to determine if the model needs to be recompiled. Remove all the time stamp comparison code since it is complicated and error prone.\n\nPrecompiled models that are supplied with the windows installer will need to include the tag, which may complicate the installer.  Are precompiled models needed given that !SasView ships with tinycc?\n\nOpenCL kernels already use the tag for testing if a recompile is needed.  It also check timestamps, so kernelcl.py should also be updated.\n\nIn practice, this issue will only be a problem for users that don't have OpenCL but are making their own versions of models with the same name as the builtin model, and still want to run the builtin model.  Currently, the most recently changed source will win.\n\n",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-10-16T20:57:38",
    "component": "SasView",
    "summary": "models with the same name in different directories will not be distinguished",
    "priority": "minor",
    "keywords": "",
    "milestone": "SasView 4.3.0",
    "owner": "butler",
    "type": "defect"
}
@butlerpd
Copy link
Member

Trac update at 2016/11/08 14:52:06:

  • butler changed owner from "" to "butler"
  • butler changed status from "new" to "assigned"

@ajj
Copy link
Member

ajj commented Mar 30, 2019

Trac update at 2017/03/16 20:40:12: ajj changed milestone from "SasView 4.1.0" to "SasView 4.2.0"

@butlerpd
Copy link
Member

Trac update at 2018/02/13 02:29:31: butler changed milestone from "SasView 4.2.0" to "SasView 4.3.0"

@ricleal ricleal transferred this issue from SasView/sasview Apr 23, 2019
@butlerpd butlerpd added this to the sasmodels 1.1 milestone May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants