Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn users if they are asking DREAM for too many samples (Trac #799) #899

Open
pkienzle opened this issue Mar 30, 2019 · 3 comments
Open
Assignees
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour
Milestone

Comments

@pkienzle
Copy link
Contributor

pkienzle commented Mar 30, 2019

Users are confused about the difference between "Samples", "Steps" and "Burn-in Steps" in DREAM. They are increasing #samples to unreasonable levels instead of using burn-in. This can cause the user inteface to fail after DREAM has spent days collecting samples when it tries to create plots with ridiculous numbers of samples.

Explanation

Samples is the number of samples to save. From this we can derive #steps = #samples/(#pars*#pop) + 1.

If steps is greater than zero then samples is ignored.

Total number of steps is #burn + #steps.

On completion, all but the final steps are saved, so even if you hit stop before burn is complete you still get #steps*#pop*#pars samples (or less if fewer than #steps iterations have passed before you hit stop).

To do

(1) Make sure the explanation is clear in the documentation, tool tips and help

(2) Warn users if they are asking for more than 1M samples, or maybe limit users to 1M samples unless they are running from the command line.

Alternative

(1) Revise inputs:

Samples: #samples used for stats; does not change iterations
Steps: #iterations to run; if running a fit without changing the model, use resume so that it collects more data points without having to go through a burn-in period

(2) Show minimum steps required to collect the desired number of samples

Migrated from http://trac.sasview.org/ticket/799

{
    "status": "assigned",
    "changetime": "2017-10-26T12:48:15",
    "_ts": "2017-10-26 12:48:15.340110+00:00",
    "description": "Users are confused about the difference between \"Samples\", \"Steps\" and \"Burn-in Steps\" in DREAM.  They are increasing #samples to unreasonable levels instead of using burn-in.  This can cause the user inteface to fail **after** DREAM has spent days collecting samples when it tries to create plots with ridiculous numbers of samples.\n\n**Explanation**\n\nSamples is the number of samples to save.  From this we can derive #steps = #samples/(#pars*#pop) + 1.\n\nIf steps is greater than zero then samples is ignored.\n\nTotal number of steps is #burn + #steps.\n\nOn completion, all but the final steps are saved, so even if you hit stop before burn is complete you still get #steps*#pop*#pars samples (or less if fewer than #steps iterations have passed before you hit stop).\n\n**To do** \n\n(1) Make sure the explanation is clear in the documentation, tool tips and help\n\n(2) Warn users if they are asking for more than 1M samples, or maybe limit users to 1M samples unless they are running from the command line.\n\n**Alternative**\n\n(1) Revise inputs:\n\n    Samples: #samples used for stats; does not change iterations\n    Steps: #iterations to run; if running a fit without changing the model, use resume so that it collects more data points without having to go through a burn-in period\n\n(2) Show minimum steps required to collect the desired number of samples",
    "reporter": "pkienzle",
    "cc": "",
    "resolution": "",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-11-02T17:32:14",
    "component": "SasView",
    "summary": "Warn users if they are asking DREAM for too many samples",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 5.0.0",
    "owner": "ajj",
    "type": "enhancement"
}
@pkienzle pkienzle added this to the SasView 5.0.0 milestone Mar 30, 2019
@pkienzle pkienzle added Enhancement Feature requests and/or general improvements Incomplete Migration Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2016/11/08 15:11:48:

  • butler commented:

Andrew to see if he can get into bumps and make the string change to GUI -- Paul K can help guide

  • butler changed owner from "" to "ajj"
  • butler changed status from "new" to "assigned"

@butlerpd
Copy link
Member

Trac update at 2017/03/08 14:44:42:

  • butler commented:

As discussed at Tuesday meeting Andrew will not have time to work on this for release 4.1 so moving to 4.2

  • butler changed milestone from "SasView 4.1.0" to "SasView 4.2.0"

@butlerpd
Copy link
Member

Trac update at 2017/10/26 12:48:15: butler changed milestone from "SasView 4.2.0" to "SasView 5.0.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and/or general improvements Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

5 participants