Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish translation to resources #418

Closed
dafarias opened this issue Oct 14, 2022 · 5 comments
Closed

Add Spanish translation to resources #418

dafarias opened this issue Oct 14, 2022 · 5 comments
Assignees
Labels

Comments

@dafarias
Copy link
Contributor

dafarias commented Oct 14, 2022

Hello!

Based on #371, I'd like to work in the feature or enhancement to add the Spanish translation based on the messages_en_US.properties file.

I'm also new to making contributions into open source, so I'm open to any suggestions.

Thank you.

@preetkaran20
Copy link
Member

preetkaran20 commented Oct 14, 2022

Hi @dafarias,

Sure, please go ahead with the implementation. Along with this change, can you also try for #416 ? This task is to use the Request locale header and pick the right locale file.

please let me know if you have any questions.

thanks,
Karan

@dafarias
Copy link
Contributor Author

Yeah, I might be giving it a try after getting done with this one. But It could take a little bito, since I'm kinda tight with deadlines right now. I'll let you know any changes or updates.

Thanks,

@preetkaran20
Copy link
Member

@dafarias perfect !!! sure.

@preetkaran20
Copy link
Member

Hi @dafarias ,

I have included the support of Accept Language header so when you now try to launch the application after spanish changes, it should launch application in spanish.

thanks,
Karan

@preetkaran20
Copy link
Member

Thanks you !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants