Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hydra, transient are loaded too eagerly in the generated autoload file #40

Open
daanturo opened this issue Apr 27, 2023 · 1 comment · May be fixed by #41
Open

Hydra, transient are loaded too eagerly in the generated autoload file #40

daanturo opened this issue Apr 27, 2023 · 1 comment · May be fixed by #41

Comments

@daanturo
Copy link

daanturo commented Apr 27, 2023 •
edited
Loading

Hello, thank you for the new cool interfaces!

Currently, the way powerthesaurus defines the hydra and transient is not so performant: it dumps the whole code block into the autoload file, and forcefully loads hydra.el and transient.el too early in the startup process.

While not invalidating the fix for #36 and still address this loading issue, I think we can opt to move those to a separate like https://github.com/emacs-lsp/dap-mode/blob/master/dap-hydra.el does.

Also a small feature request from me: add "q" to quit transient, similar to the hydra one.
@daanturo daanturo linked a pull request Apr 27, 2023 that will close this issue
Open
hlissner added a commit to doomemacs/doomemacs that referenced this issue Jul 24, 2023
@hlissner
fix(lookup): powerthesaurus eager-loading transient, hydra, lv
f0b58fc 
SavchenkoValeriy/emacs-powerthesaurus@782df1d92f95 causes hydra and
transient (and their dependencies) to be eagerly loaded very, very early
during startup. This causes load errors for some, terrible startup time
for others. This swaps the module to a fork with a fix.

Amend: 8b892f5
Ref: SavchenkoValeriy/emacs-powerthesaurus@782df1d92f95
Ref: SavchenkoValeriy/emacs-powerthesaurus#40
Ref: #7204
akhil3417 pushed a commit to akhil3417/doomemacsonsteroids that referenced this issue Jul 29, 2023
@hlissner @akhil3417
fix(lookup): powerthesaurus eager-loading transient, hydra, lv
b11b560 
SavchenkoValeriy/emacs-powerthesaurus@782df1d92f95 causes hydra and
transient (and their dependencies) to be eagerly loaded very, very early
during startup. This causes load errors for some, terrible startup time
for others. This swaps the module to a fork with a fix.

Amend: 8b892f5
Ref: SavchenkoValeriy/emacs-powerthesaurus@782df1d92f95
Ref: SavchenkoValeriy/emacs-powerthesaurus#40
Ref: doomemacs#7204
akhil3417 pushed a commit to akhil3417/doomemacsonsteroids that referenced this issue Jul 29, 2023
@hlissner @akhil3417
fix(lookup): powerthesaurus eager-loading transient, hydra, lv
f63e74f 
SavchenkoValeriy/emacs-powerthesaurus@782df1d92f95 causes hydra and
transient (and their dependencies) to be eagerly loaded very, very early
during startup. This causes load errors for some, terrible startup time
for others. This swaps the module to a fork with a fix.

Amend: 8b892f5
Ref: SavchenkoValeriy/emacs-powerthesaurus@782df1d92f95
Ref: SavchenkoValeriy/emacs-powerthesaurus#40
Ref: doomemacs#7204
akhil3417 pushed a commit to akhil3417/doomemacsonsteroids that referenced this issue Jul 29, 2023
@hlissner @akhil3417
fix(lookup): powerthesaurus eager-loading transient, hydra, lv
74ac6ff 
SavchenkoValeriy/emacs-powerthesaurus@782df1d92f95 causes hydra and
transient (and their dependencies) to be eagerly loaded very, very early
during startup. This causes load errors for some, terrible startup time
for others. This swaps the module to a fork with a fix.

Amend: 8b892f5
Ref: SavchenkoValeriy/emacs-powerthesaurus@782df1d92f95
Ref: SavchenkoValeriy/emacs-powerthesaurus#40
Ref: doomemacs#7204
@noctuid
Copy link

noctuid commented Feb 18, 2024

Would also like to see this changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lazyloading for transient and hydra daanturo/emacs-powerthesaurus
2 participants
@noctuid @daanturo