Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The tests for SceptrePlan are pretty terrible and could use being completely redone #1250

Open
jfalkenstein opened this issue Jul 24, 2022 · 3 comments

Comments

@jfalkenstein
Copy link
Contributor

In looking over our codebase recently, I discovered that our tests on SceptrePlan are downright bad. Test coverage is poor, it doesn't really test all the functionality, and they're not very easy to read or maintain.

Ideally, we would have tests that cover all "public" methods of the class and validate the expected outcomes against the actual outcomes.

This is a very useful, low-risk opportunity for those looking to contribute to Sceptre.

@jfalkenstein jfalkenstein changed the title The tests for SceptrePlan are pretty terrible and could use being completely redone. The tests for SceptrePlan are pretty terrible and could use being completely redone Jul 24, 2022
@ericabrauer
Copy link
Contributor

You can add me as an assignee, not sure how much bandwidth I have vs how much workload there is but I can at least start with taking a stab at breaking this out into chunks. Any help/paired programming sessions would definitely be appreciated :)

@jfalkenstein
Copy link
Contributor Author

@ericabrauer, I'd be happy to assist ; )

@alex-harvey-z3q
Copy link
Contributor

@ericabrauer I would be inclined to close this issue unless you are still working on it? We all know that the tests aren't perfect, but without Jon here to help, it seems unlikely it could get prioritised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants