Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing Meaning Errors when launching a stack group #640

Closed
jmsuzuki opened this issue Feb 17, 2019 · 5 comments
Closed

Providing Meaning Errors when launching a stack group #640

jmsuzuki opened this issue Feb 17, 2019 · 5 comments

Comments

@jmsuzuki
Copy link

jmsuzuki commented Feb 17, 2019

When launching stack groups, if one of the stack config's templates is invalid, meaningful errors are not bubble up.

I have to launch the specific template to get error that needs to be fixed.
Finding the specific template to launch to get the error back can be frustrating and time consuming with multiple templates.

$ sceptre launch beta\\service
Do you want to launch 'beta\service' [y/N]: y
[2019-02-16 23:14:41] - beta\service\rabbitmq - Launching Stack
[2019-02-16 23:14:41] - beta\service\audit - Launching Stack
[2019-02-16 23:14:41] - beta\service\ecs-cluster - Launching Stack
[2019-02-16 23:14:42] - beta\service\audit - Stack is in the PENDING state
[2019-02-16 23:14:42] - beta\service\audit - Creating Stack
[2019-02-16 23:14:42] - beta\service\rabbitmq - Stack is in the CREATE_COMPLETE state
[2019-02-16 23:14:42] - beta\service\rabbitmq - Updating Stack
[2019-02-16 23:14:42] - beta\service\ecs-cluster - Stack is in the PENDING state
[2019-02-16 23:14:42] - beta\service\ecs-cluster - Creating Stack
[2019-02-16 23:14:43] - beta\service\rabbitmq - No updates to perform.
Stack with id beta-service-ecs-cluster does not exist
(venv)
Mitchell@MitchellSuzuki
$ sceptre launch beta\\service\\ecs-cluster
Do you want to launch 'beta\service\ecs-cluster' [y/N]: y
[2019-02-16 23:14:57] - beta\service\ecs-cluster - Launching Stack
[2019-02-16 23:14:58] - beta\service\ecs-cluster - Stack is in the PENDING state
[2019-02-16 23:14:58] - beta\service\ecs-cluster - Creating Stack
An error occurred (ValidationError) when calling the CreateStack operation: Parameters: [RabbitSecurityGroup] do not exist in the template
@ngfgrant
Copy link
Contributor

Better, more useful error reporting is definitely something that has been front of mind. I think we probably need to adjust the response structure from executor or actions such that they are able to capture the response and any errors e.g.

{
    "response": [], 
    "errors": []
}

Worth having a discussion on this point because we will apply the solution across the whole project.

@alytle
Copy link

alytle commented Apr 1, 2019

This is causing me a great deal of grief currently, as I'm working on a project with a large number of stacks. I've had to resort to adding print statements within StackActions to find out which Stack is actually causing the error.

@ngfgrant ngfgrant modified the milestone: 2.1.3 May 9, 2019
@mvanholsteijn
Copy link

We have the same issue. What type of discussion would help this issue forward?

@ngfgrant
Copy link
Contributor

Yep this would be good to incorporate. Currently trying to catch up with things.

@craighurley
Copy link
Contributor

Closing as #997 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants