[Resolves #961]: Hook.stack is not necessarily the stack actually being updated #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zaro0508 could you please review? In our work we have some hooks where we have to execute certain boto3 calls after the stack A is deployed and we need to pass to our hook X outputs from the stack A (work with TGW) and this PR straightens our workarounds |
zaro0508
requested changes
Aug 3, 2021
|
|
||
| """ | ||
| def __init__(self, *args, **kwargs): | ||
| super(CustomHook, self).__init__(*args, **kwargs) | ||
|
|
||
| def run(self): | ||
| def run(self, stack): |
There was a problem hiding this comment.
thanks for the contribution however I don't think we can break every Sceptre custom hook out in the wild. I would prefer a more general solution that would allow hooks or resolvers to access the stack object.
If this is the only solution then i think it would need to be done with a new interface and then deprecating the old one.
|
@gilleswijnker @ykhalyavin Is it ok for me to close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Resolves #961]: Hook.stack is not necessarily the stack actually being updated.
Please note this request introduces a breaking change for custom Hooks.
Hook.stackhas been removed.Hook.runnow accepts a single parameterstack.PR Checklist
[Resolve #issue-number].make test) are passing.pre-commit run --all-files).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit