Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no-avg parameter specified but it creates the same image #11

Open
BugliL opened this issue Sep 21, 2022 · 5 comments
Open

--no-avg parameter specified but it creates the same image #11

BugliL opened this issue Sep 21, 2022 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@BugliL
Copy link
Contributor

BugliL commented Sep 21, 2022

I run the client with -na parameter with a rainbow image (this one https://github.com/BugliL/ImageGoNord-cli/blob/develop/tests/data/rainbow_square.png) but it seems to have no differences.
Do I need to specify more parameters?

To Reproduce
Steps to reproduce the behavior: Clone my fork repository and run tests
You can find a test here https://github.com/BugliL/ImageGoNord-cli/blob/develop/tests/unit/test_client_advanced_behavior.py

The full commands are

python /home/buglil/Desktop/ImageGoNord-cli/src/cli.py -i=/home/buglil/Desktop/ImageGoNord-cli/tests/data/rainbow_square.png -o=/tmp/tmpen591wm6/output.png -na
python /home/buglil/Desktop/ImageGoNord-cli/src/cli.py -i=/home/buglil/Desktop/ImageGoNord-cli/tests/data/rainbow_square.png -o=/tmp/tmpen591wm6/output.png 

Expected behavior
Having a different image if -na applied or not
Start image https://github.com/BugliL/ImageGoNord-cli/blob/develop/tests/data/rainbow_square.png
Image with -na option https://github.com/BugliL/ImageGoNord-cli/blob/develop/tests/data/rainbow_nord_na_square.png
Image without -na option https://github.com/BugliL/ImageGoNord-cli/blob/develop/tests/data/rainbow_nord_square.png

  • OS: 20.04.1-Ubuntu
  • Venv Python 3.9.9
@Wabri Wabri added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Sep 27, 2022
@Wabri
Copy link
Member

Wabri commented Sep 27, 2022

You are right, it seems something is broken on this option.

@BugliL
Copy link
Contributor Author

BugliL commented Sep 30, 2022

I checked the code and this do not seems to be a client problem, can you confirm it?

@Wabri
Copy link
Member

Wabri commented Oct 4, 2022

I guess so, we should open a issue on the imagegonord-pip

@TheJoin95
Copy link
Member

What was the issue on this one? @Wabri @BugliL ?

@Wabri
Copy link
Member

Wabri commented Apr 16, 2024

Is it not clear in the description?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants