Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli - Refactoring with Argparse #2

Closed
BugliL opened this issue Feb 24, 2022 · 10 comments
Closed

Cli - Refactoring with Argparse #2

BugliL opened this issue Feb 24, 2022 · 10 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BugliL
Copy link
Contributor

BugliL commented Feb 24, 2022

I think the client is not so much pythonic, can I try to provide a version with argparse?

@github-actions
Copy link

Thanks for contributing to the project! We will reply as soon as possible to your problem or request :)

@Wabri
Copy link
Member

Wabri commented Feb 24, 2022

Of course, I was already thinking about it, but other projects got in my way 😅

@Wabri Wabri added enhancement New feature or request good first issue Good for newcomers labels Feb 24, 2022
@Wabri
Copy link
Member

Wabri commented Feb 28, 2022

@BugliL sorry for the shitty code 😬

@BugliL
Copy link
Contributor Author

BugliL commented Feb 28, 2022

It Works so It's good, it just need a little bit of refactoring to implement more options clearly

@Artmorse
Copy link
Contributor

Hi,

Before create a PR for the issue #3, i would like to close this one, I will propose you a PR very soon!

@Wabri
Copy link
Member

Wabri commented Aug 26, 2022

Hi @Artmorse will you plan to use argpars in your pr?

@Wabri
Copy link
Member

Wabri commented Aug 26, 2022

@BugliL have you done anything on this issue yet?

@Artmorse
Copy link
Contributor

Yes I want to close this issue before starting the #3 one.

@BugliL
Copy link
Contributor Author

BugliL commented Aug 29, 2022

@BugliL have you done anything on this issue yet?

I have a new version on my repository that should be updated with last commits. It is quite ready.
I will do it as soon as I can.

@Artmorse
Copy link
Contributor

If you need some help, don't hesistate!

@Wabri Wabri transferred this issue from Schroedinger-Hat/ImageGoNord-Web Sep 1, 2022
Wabri pushed a commit that referenced this issue Sep 27, 2022
Current client Tests done
@BugliL BugliL closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants