Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newsletter error feedback #525

Merged

Conversation

Balastrong
Copy link
Contributor

Hey! I tried to signup to the newsletter but... nothing happened!
Turns out I was already registered but I didn't get any feedback from the page when I was trying to signup again.

I fixed a couple things there:

  • If the email is invalid we set the border red, but this is visible only if the input is focused and it loses focus when you click the button -> now it refocuses the input if that's the case
  • The waiting state (changing the button text and preventing further clicks) wasn't set
  • I added an ugly alert to inform if the user is already registered or if a generic error happened.

Let me know what you think! I did 3 separate commits so if we want to keep some and discard others it's easy :)

Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for keen-banoffee-86ed50 ready!

Name Link
🔨 Latest commit c60de1c
🔍 Latest deploy log https://app.netlify.com/sites/keen-banoffee-86ed50/deploys/65f3594ec1837a0008097a5f
😎 Deploy Preview https://deploy-preview-525--keen-banoffee-86ed50.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@TheJoin95 TheJoin95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement, looking good, merging

@TheJoin95 TheJoin95 merged commit 754c7ce into Schroedinger-Hat:2024 Mar 14, 2024
4 checks passed
@Balastrong Balastrong deleted the fix/newsletter-error-feedback branch March 14, 2024 20:22
@Wabri
Copy link
Member

Wabri commented Mar 22, 2024

Thanks @Balastrong the brightest star 🌟

@Balastrong
Copy link
Contributor Author

Anything for the chairman @Wabri 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants