Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed of the IDE model #1077

Closed
2 tasks done
lenaploetzke opened this issue Jul 29, 2024 · 3 comments
Closed
2 tasks done

Improve speed of the IDE model #1077

lenaploetzke opened this issue Jul 29, 2024 · 3 comments
Assignees
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ide This issue concerns any kind of integro differential equations-based model. prio::moderate The priority of this task is moderate.

Comments

@lenaploetzke
Copy link
Member

Motivation / Current Behaviour

Currently, simulation with the IDE model takes a long time, especially with small time step sizes, e.g. 1e-4. (several hours for a simulation time of 35 days in release mode)

Enhancement description

We should try to reduce the runtime. An experiment in Valgrind has demonstrated that a significant proportion of the runtime is allocated to the evaluation of the StateAgeFunctions. As the same StateAgeFunction is currently evaluated several times at the same time point, the potential for saving runtime could be highest here.

Additional context

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@lenaploetzke lenaploetzke added prio::moderate The priority of this task is moderate. loc::backend This issue concerns the C++ backend implementation. model::ide This issue concerns any kind of integro differential equations-based model. class::improvement Cleanup that doesn't affect functionality labels Jul 29, 2024
@lenaploetzke
Copy link
Member Author

@annawendler Is this actually also resolved by #1129 ?

@annawendler
Copy link
Member

I would say so for now.

@annawendler
Copy link
Member

As the run time of the IDE model was reduced significantly in #1129, we consider this issue resolved for now.

@github-project-automation github-project-automation bot moved this from Product Backlog to ✅ Done (Sprint) in MEmilio: Equation-Based-Models Development Oct 7, 2024
@mknaranja mknaranja moved this from ✅ Done (Sprint) to Done (Total) in MEmilio: Equation-Based-Models Development Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ide This issue concerns any kind of integro differential equations-based model. prio::moderate The priority of this task is moderate.
Projects
Development

No branches or pull requests

2 participants