Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance should be dependent on infected persons #1115

Open
2 tasks done
xsaschako opened this issue Aug 22, 2024 · 2 comments
Open
2 tasks done

Performance should be dependent on infected persons #1115

xsaschako opened this issue Aug 22, 2024 · 2 comments
Assignees
@xsaschako
Labels
class::improvement Cleanup that doesn't affect functionality class::performance Performance related issues good first issue Good for newcomers model::abm This issue concerns any kind of agent-based model.

Comments

@xsaschako
Copy link
Member

Motivation / Current Behaviour

Currently it doesnt make a huge difference, if a lot of people are infectious for the runtime.
But it should, as we do alot of unneccessary work.

Enhancement description

We need to just do it for a cell/location with a transmission risk. Currently we do this for every location.

Additional context

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@xsaschako xsaschako added good first issue Good for newcomers model::abm This issue concerns any kind of agent-based model. class::improvement Cleanup that doesn't affect functionality class::performance Performance related issues labels Aug 22, 2024
@xsaschako xsaschako self-assigned this Aug 22, 2024
@xsaschako
Copy link
Member Author

xsaschako commented Aug 22, 2024 •
edited
Loading

On paper branch: when caching exposure rate flag location as infecitous.
On main: probablysame

@xsaschako
Copy link
Member Author

first tests on main show a 20% performance gain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xsaschako xsaschako

Labels
class::improvement Cleanup that doesn't affect functionality class::performance Performance related issues good first issue Good for newcomers model::abm This issue concerns any kind of agent-based model.
Projects
MEmilio: Agent-Based-Model Development
Status: Product Backlog 📕
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xsaschako