Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commuter Testing should not be coupled with dynamic NPIs #1116

Open
2 tasks done
HenrZu opened this issue Aug 28, 2024 · 0 comments
Open
2 tasks done

Commuter Testing should not be coupled with dynamic NPIs #1116

HenrZu opened this issue Aug 28, 2024 · 0 comments
Assignees
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. prio::low The priority of this task is low. It is an interesting item but with low priority.

Comments

@HenrZu
Copy link
Contributor

HenrZu commented Aug 28, 2024

Motivation / Current Behaviour

in the advance function of the secirvvs model, we always set

this->get_model().parameters.get_start_commuter_detection() = (ScalarType)t_start;
this->get_model().parameters.get_end_commuter_detection()   = (ScalarType)t_end;

Testing should not necessarily be coupled to the dynamic NPIs in this way. Also, we can't change the non detection value during the simulation.

Enhancement description

make the code more modular and split up features instead of combining them.

Additional context

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@HenrZu HenrZu added prio::low The priority of this task is low. It is an interesting item but with low priority. loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. class::improvement Cleanup that doesn't affect functionality labels Aug 28, 2024
@HenrZu HenrZu self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::ode This issue concerns any kind of ODE-based model. prio::low The priority of this task is low. It is an interesting item but with low priority.
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant