Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParameterDistributionNormal does not work if only mean and stddev are set #1131

Open
2 tasks done
jubicker opened this issue Sep 30, 2024 · 0 comments
Open
2 tasks done

ParameterDistributionNormal does not work if only mean and stddev are set #1131

jubicker opened this issue Sep 30, 2024 · 0 comments
Labels
class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. model::hybrid model::ide This issue concerns any kind of integro differential equations-based model. model::ode This issue concerns any kind of ODE-based model.

Comments

@jubicker
Copy link
Member

Bug description

The class ParameterDistributionNormal has several constructors, one where only mean and standard_dev are set. If this constructor is used the members m_lower_bound and m_upper_bound are not set i.e. they are 0. When the function get_rand_sample() is called mean and standard_dev are set to zero as well. (in check_quantiles)

Version

Linux

To reproduce

  1. Create object ParameterDistributionNormal(mean, std_dev).
  2. Call function get_rand_sample()

Relevant log output

No response

Add any relevant information, e.g. used compiler, screenshots.

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@jubicker jubicker added class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. model::ode This issue concerns any kind of ODE-based model. model::ide This issue concerns any kind of integro differential equations-based model. model::hybrid labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
class::bug Bugs found in the software loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. model::hybrid model::ide This issue concerns any kind of integro differential equations-based model. model::ode This issue concerns any kind of ODE-based model.
Projects
MEmilio: Agent-Based-Model Development
Status: Product Backlog 📕
MEmilio: Equation-Based-Models Development
Status: Product Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jubicker