Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check_constraint function returns true when parameters are set to wrong values #1157

Open
2 tasks done
jubicker opened this issue Dec 9, 2024 · 0 comments
Open
2 tasks done

Check_constraint function returns true when parameters are set to wrong values #1157

jubicker opened this issue Dec 9, 2024 · 0 comments
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. model::ode This issue concerns any kind of ODE-based model.

Comments

@jubicker
Copy link
Member

jubicker commented Dec 9, 2024

Motivation / Current Behaviour

The check_constraint functions should check whether the parameters are set to acceptible values e.g. if stay times are > 0. If the constraint is not fulfilled i.e. a parameter has a not permitted value, the function returns true.

Enhancement description

It would be more intuitive if the function returned true for permitted values and false for not permitted values.

Additional context

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@jubicker jubicker added loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. model::ode This issue concerns any kind of ODE-based model. class::improvement Cleanup that doesn't affect functionality labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. model::ode This issue concerns any kind of ODE-based model.
Projects
MEmilio: Agent-Based-Model Development
Status: Product Backlog 📕
MEmilio: Equation-Based-Models Development
Status: Product Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jubicker