Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters in ABM simulation aren't set correctly. #811

Open
2 tasks done
DavidKerkmann opened this issue Oct 26, 2023 · 1 comment
Open
2 tasks done

Parameters in ABM simulation aren't set correctly. #811

DavidKerkmann opened this issue Oct 26, 2023 · 1 comment
Assignees
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. prio::high The priority of this task is high.

Comments

@DavidKerkmann
Copy link
Member

Motivation / Current Behaviour

In the setting of the parameters in the simulation, there is some code duplication and some unclear parameter settings.
We have

infection_params.get<mio::abm::InfectedNoSymptomsToSymptoms>()[{mio::abm::VirusVariant::Wildtype,
                                                                    mio::abm::AgeGroup::Age0to4}]  = 0.276;

and later

infection_params.get<mio::abm::InfectedNoSymptomsToSymptoms>()[{mio::abm::VirusVariant::Wildtype,
                                                                    mio::abm::AgeGroup::Age0to4}]  = 0.161;

Similar with other parameters. This duplication/error probably stems from the removal of vaccination as a part of the parameters. These parameters currently represent a time per day, so this would be only a couple of hours in this case, but some other parameters are even lower and all of them seem to be wrong.

Enhancement description

Perhaps they are supposed to be the percentage of people that transition to these compartments rather than the time spent. Someone should have a look at this, in particular we need fitting values once #664 gets merged.

Additional context

No response

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@DavidKerkmann DavidKerkmann added prio::high The priority of this task is high. loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. class::improvement Cleanup that doesn't affect functionality labels Oct 26, 2023
@DavidKerkmann DavidKerkmann moved this from Product Backlog to Next up in MEmilio: Agent-Based-Model Oct 26, 2023
@DavidKerkmann DavidKerkmann moved this from Next up to Sprint Backlog in MEmilio: Agent-Based-Model Oct 30, 2023
@xsaschako xsaschako moved this from Product Backlog to Sprint Backlog in MEmilio: Agent-Based-Model Development Nov 21, 2023
@DavidKerkmann DavidKerkmann moved this from Sprint Backlog 🏃‍♂️ to Next up 🆙 in MEmilio: Agent-Based-Model Development Jan 8, 2024
@xsaschako xsaschako moved this from Next up 🆙 to Sprint Backlog 🏃‍♂️ in MEmilio: Agent-Based-Model Development Jan 22, 2024
@DavidKerkmann DavidKerkmann moved this from Sprint Backlog 🏃‍♂️ to Development 🧑‍💻👩‍💻 in MEmilio: Agent-Based-Model Development Apr 15, 2024
@DavidKerkmann
Copy link
Member Author

It has to be mentioned what the sources of the individual values are for all parameters that are set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. prio::high The priority of this task is high.
Projects
Status: Development 🧑‍💻👩‍💻
Development

No branches or pull requests

1 participant