Update spatial models for new MTK release #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorkelE
commented
Nov 22, 2024
| @@ -8,7 +8,7 @@ const GridLattice{N, T} = Union{Array{Bool, N}, CartesianGridRej{N, T}} | |||
| """ | |||
| $(TYPEDEF) | |||
|
|
|||
| A representation of a spatial system of chemical reactions on a discrete (lattice) space. | |||
There was a problem hiding this comment.
Suddenly all my PRs have started to remove random spaces from any files I touch. Nothing bad, but does clog up the PR changes. Have seen it with other PRs earlier as well.
There was a problem hiding this comment.
This is probably some VSCode setting you want to turn off.
|
Feel free to merge if you are happy with this / done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detecting hierarchical models is different now, so needed to update how this is checked. Since these now are flattened, in principle it should work for spatial modelling. However, we really haven't tested it, so nothing I recommend. Still, I changed it to a warning for the new version.