Update to MTK 9 #128
Merged
Update to MTK 9 #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I cannot reproduce the downgrade issue locally with https://github.com/julia-actions/julia-downgrade-compat/blob/main/downgrade.jl . |
|
I wouldn't worry too much about downgrade. Is the only failure now Aqua? |
|
Yes. Aqua only fails in CI. It does not fail locally. I will try to dig into this later. |
|
The last commit should fix the compat issue. However, I could not find any way to reproduce the CI failure locally. Edit: Can now (thanks to Fredrik Ekre) |
|
Okay the Aqua failure is essentially SciML/ModelingToolkit.jl#2827. I think I can fix this. |
|
CI fails now locally with a different error using the SymbolicUtils.jl fix. But the Aqua issue seems to be resolved at least. |
|
I think I fixed all issues now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to new MTK version and hot-fixes master CI.