Add ODE_DEFAULT_NORM
overload for GTPSA
#1108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
I added an overload for
ODE_DEFAULT_NORM
withTPS
types where it calculates the 2-norm of the scalar (0th order) part of theTPS
, and is necessary because the GTPSA C library does not allowsqrt(TPS(0))
as the derivatives are undefined.The calculation of the norm of the scalar part follows from what I see in the
Tracker
extension. If instead it should calculate a norm including all monomial coefficients/partial derivatives, I can quickly change that to the functionGTPSA.normTPS
.