Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What to do about FFJORD here? #816

Closed
ChrisRackauckas opened this issue Mar 6, 2023 · 2 comments
Closed

What to do about FFJORD here? #816

ChrisRackauckas opened this issue Mar 6, 2023 · 2 comments

Comments

@ChrisRackauckas
Copy link
Member

@prbzrg I saw your https://github.com/impICNF/ICNF.jl which seems to have a lot of FFJORD things, should FFJORD and all just be a whole separate repo and pull that into SciML? If you have things in good shape then I would prefer to just reuse that code and then make sure any GSoC is implementing algorithms separate from that.
@prbzrg
Copy link
Member

prbzrg commented Mar 7, 2023

Thanks for your attention, I will be glad to move it to SciML.
The API is good, and I don't have any plan to change it.
The documentation is poor, but the amount of function to be documented is a few.
The performance is similar to DiffEqFlux.
There are smoke tests, but we need some regression tests.

@ChrisRackauckas
Copy link
Member Author

Updated in the latest version by @avik-pal . I think we should still link to https://github.com/impICNF/ContinuousNormalizingFlows.jl in the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisRackauckas @prbzrg