Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom linear solve documentation #502

Open
ArnoStrouwen opened this issue May 13, 2024 · 1 comment
Open

Custom linear solve documentation #502

ArnoStrouwen opened this issue May 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ArnoStrouwen
Copy link
Member

Why are there 2 methods for doing custom linear solves:
https://docs.sciml.ai/LinearSolve/dev/advanced/custom/
https://docs.sciml.ai/LinearSolve/dev/advanced/developing/
it is not clear to me when to use one over the other method.

In the latter method, in the function SciMLBase.solve!,
it is not clear how the A matrix is passed.
It would be better if this was a full runnable example.

There are inplace and outofplace problems.
Neither of the two methods seems to interact with this aspect of the problem.
It is unclear to me what is actually mutated in an inplace problem with a concrete A.

@ArnoStrouwen ArnoStrouwen added the bug Something isn't working label May 13, 2024
@ChrisRackauckas
Copy link
Member

One is for developing new linear solvers, i.e. devdocs for this package. The other is a shorthand for passing in custom linear solver code by users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants