fix: convert Symbol to symbolic variables in remake, fix split_idxs
#2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -142,11 +142,19 @@ function SciMLBase.process_p_u0_symbolic(prob::Union{SciMLBase.AbstractDEProblem | |||
| hasproperty(prob.f, :sys) && hasfield(typeof(prob.f.sys), :ps) || | |||
| throw(ArgumentError("This problem does not support symbolic maps with `remake`, i.e. it does not have a symbolic origin." * | |||
| " Please use `remake` with the `p` keyword argument as a vector of values, paying attention to parameter order.")) | |||
| p = [ | |||
| (symbolic_type(sym) != NotSymbolic() ? parameter_symbols(prob)[parameter_index(prob, sym)] : sym) => val | |||
There was a problem hiding this comment.
Shouldn't it be the other way around, to always canonicalize to name?
There was a problem hiding this comment.
The way the defs map is created below and get_u0_p works requires canonicalizing to values from parameter_symbols
|
What's left here? |
|
Nothing. This is required for SciML/SciMLBase.jl#583 to pass |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.