Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completeness for use in OrdinaryDiffEq.jl #247

Closed
ChrisRackauckas opened this issue Oct 18, 2023 · 2 comments
Closed

Completeness for use in OrdinaryDiffEq.jl #247

ChrisRackauckas opened this issue Oct 18, 2023 · 2 comments

Comments

@ChrisRackauckas
Copy link
Member

This package is almost complete to be used in OrdinaryDiffEq.jl. For other discussions on this topic, see SciML/OrdinaryDiffEq.jl#1570

However, there are some special things done in its nonlinear solvers which we would need to allow for here:

  1. First step is completing the iterator interface Complete the iterator interface #241
  2. We need to have a version of a Quasi-Newton method which forces Jacobian reuse and terminates if convergence starts to fail. I think this can be done just with a SingleFactorizeNewton and some extended TerminationCondition stuff.
  3. For this SingleFactorizeNewton, we'd need to allow it in the iterator form to have a mode where changing u does not cause a new Jacobian to be taken. Thus in the cache interface, we'd need a reevalute_jacobian! that can be handled outside the solver for such cases.

Once those are together, then I think we're good to try it in OrdinaryDiffEq?

@ChrisRackauckas
Copy link
Member Author

Related #206 @frankschae

@oscardssmith
Copy link
Contributor

@ChrisRackauckas I believe this can now be closed, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants