Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GaussNewton returns unstable when problem is converged #284

Closed
vpuri3 opened this issue Nov 15, 2023 · 1 comment
Closed

GaussNewton returns unstable when problem is converged #284

vpuri3 opened this issue Nov 15, 2023 · 1 comment

Comments

@vpuri3
Copy link
Member

vpuri3 commented Nov 15, 2023

julia> sol = solve(NonlinearLeastSquaresProblem((x, p) -> x, ones(3)), GaussNewton())
u: 3-element Vector{Float64}:
 0.0
 0.0
 0.0

julia> sol.retcode
ReturnCode.Success = 1

julia> sol = solve(NonlinearLeastSquaresProblem((x, p) -> x, zeros(3)), GaussNewton())
u: 3-element Vector{Float64}:
 0.0
 0.0
 0.0

julia> sol.retcode
ReturnCode.Unstable = 6
@avik-pal
Copy link
Member

https://github.com/SciML/DiffEqBase.jl/blob/8c0db9efb1a3907e3abb596545474621986b36fc/src/termination_conditions.jl#L290 line needs to be > else if the initial point is the solution, we hit protective termination

ChrisRackauckas added a commit to SciML/DiffEqBase.jl that referenced this issue Nov 17, 2023
Fixes nonlinear termination condition convergance (SciML/NonlinearSolve.jl#284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants