-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] Change weights generation to follow WeightInitializers.jl #184
Comments
Hi @MartinuzziFrancesco I guess I can take a look at this, if you can elaborate a bit what exactly needs to be done here. |
Hi, of course! So at the moment the construction of the input layers matrices and reservoir matrices uses abstract typing and dispatch over different using ReservoirComputing, Random
rng = MersenneTwister(42)
# Passing kwargs with explicit rng call
res_cl = rand_sparse(rng; sparsity=0.1, spectral_radius=1.0)
#res_cl is now a callable function that takes in the size of the reservoir
reservoir_weights = res_cl(rng, 10, 10)
# Passing kwargs with default rng call
res_cl = rand_sparse(; sparsity=0.1, spectral_radius=1.0)
#res_cl is now a callable function that takes in the size of the reservoir
reservoir_weights = res_cl(10, 10) For details of the implementation you can refer to the source in WeightInitializers. I could sketch Of course after this we need to modify the This issue is part of a streamlining in order to be more in line with (F)Lux as model building philosophy. This should also make contributions a little bit easier |
@Jay-sanjay I have started a PR in #193, you can follow the template to create the remaining functions for the reservoir and input layers. I will need to think about a couple of details (and tests as well) |
Thanks @MartinuzziFrancesco for the template, I will start to work on it with other functions |
In order to streamline the package and creation of reservoir computing models the creation of the weights of the matrices should follow WeightInitializers.jl
The text was updated successfully, but these errors were encountered: