Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING: Method definition overwritten #927

Closed
prbzrg opened this issue Nov 1, 2023 · 4 comments
Closed

WARNING: Method definition overwritten #927

prbzrg opened this issue Nov 1, 2023 · 4 comments

Comments

@prbzrg
Copy link
Member

prbzrg commented Nov 1, 2023

julia> using SciMLSensitivity
WARNING: Method definition adjoint(ZygoteRules.AContext, typeof(ZygoteRules.literal_getproperty), SciMLBase.EnsembleSolution{T, N, S} where S where N where T, Base.Val{:u}) in module DiffEqBase overwritten in module SciMLBaseZygoteExt.
WARNING: Method definition _pullback(ZygoteRules.AContext, typeof(Core.kwcall), Any, typeof(ZygoteRules.literal_getproperty), SciMLBase.EnsembleSolution{T, N, S} where S where N where T, Base.Val{:u}) in module DiffEqBase at C:\Users\Hossein Pourbozorg\.julia\packages\ZygoteRules\4nXuu\src\adjoint.jl:74 overwritten in module SciMLBaseZygoteExt on the same line (check for duplicate calls to `include`).
WARNING: Method definition _pullback(ZygoteRules.AContext, typeof(ZygoteRules.literal_getproperty), SciMLBase.EnsembleSolution{T, N, S} where S where N where T, Base.Val{:u}) in module DiffEqBase at C:\Users\Hossein Pourbozorg\.julia\packages\ZygoteRules\4nXuu\src\adjoint.jl:65 overwritten in module SciMLBaseZygoteExt on the same line (check for duplicate calls to `include`).

julia>
@ChrisRackauckas
Copy link
Member

I posted on Slack:

Chris Rackauckas
2 minutes ago
Anyone have open hands and wants to help with something? #927
1 reply

Chris Rackauckas
1 minute ago
https://github.com/SciML/DiffEqBase.jl/blob/master/src/chainrules.jl we should move all of the ZygoteRules and ChainRules which are only on SciMLBase types (I think that's all of them here?) into extensions in SciMLBase, like https://github.com/SciML/SciMLBase.jl/blob/master/ext/SciMLBaseZygoteExt.jl. This would get rid of type piracy and is a simple change, but I was in the middle of it and dropped it

@prbzrg
Copy link
Member Author

prbzrg commented Nov 2, 2023

There are some rules from SciML/DiffEqFlux.jl#744

@ChrisRackauckas
Copy link
Member

Should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants