Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic CI using github actions #6

Merged
merged 2 commits into from
Jun 16, 2024
Merged

add basic CI using github actions #6

merged 2 commits into from
Jun 16, 2024

Conversation

Vindaar
Copy link
Member

@Vindaar Vindaar commented Nov 12, 2021

Let's see if this works.

Locally the tests are broken for me, which is why I wanted to set up CI.
edit: locally works fine now (nimpy setup issue), but C++ backend also causes codegen errors.

edit:
Updated to be more modern. Should work.

This one is based on the `impulse` CI (recently adjusted to use newer
action to pull Nim)
@Vindaar
Copy link
Member Author

Vindaar commented Jun 16, 2024

Merging despite the CI failure. Better set up a CI that fails than not having any...

The issue relates to the Nim compiler getting very confused in generics once again. Arraymancer nowadays has a toTensor that takes SomeSet[T]. The combination of regular generic T with a type class SomeSet = HashSet | OrderedSet makes it try to compile code as a SomeSet where it really does not make any sense. This needs to be fixed in arraymancer by splitting the SomeSet explicitly.

@Vindaar Vindaar merged commit b016671 into main Jun 16, 2024
0 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant