-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cf-units] Ruff fixes #527
Draft
ukmo-ccbunney
wants to merge
34
commits into
SciTools:main
Choose a base branch
from
ukmo-ccbunney:qa_ruff
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addressed in this branch
existing known Deprecation warnings
- Required lots of additions to the Ruff ignore list - Extra additions to mypy ignore list - Autofixes from Ruff linter - Fixes from codespell
- Removed some duplicate ruff ignores - Reorded some subsections
- Added: `force-sort-within-sections = true` - Auto updated files resultig from above - file specific ignores
- Trailing witespace - No neline at end of file - Some Ruff linting
- Add trailing / to mypy exclude paths
Added extra ignores in mypy for _udunits generated code
Re-added PY005 test to sp-repo-review ignore list.
- All instances fixed with `noqa: FBT002` as would affect API
- f-strings don't really help (it would be a mess) - triple quotes preserve indentation - backslash at end of string for continuation is nasty and requires manually adding \n newlines
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #527 +/- ##
==========================================
+ Coverage 58.41% 58.46% +0.04%
==========================================
Files 62 62
Lines 6435 6447 +12
Branches 1150 1150
==========================================
+ Hits 3759 3769 +10
- Misses 2385 2387 +2
Partials 291 291 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Note: This branch is currently based on qa_reresh_pre-commit-hooks branch, but will rebase on main once that branch is merged. First relevant commit is 2fc5e4f
Addresses failing Ruff tests, as described in #526
Not exhaustive, currently addresses following (see individual commits for details)
EM101
raw-string-in-exceptionFLY002
Consider f-string instead of string join :FBT002
boolean-default-value-positional-argument.noqa: FBT002
as would affect APID401
non-imperative-moodD404
docstring-starts-with-thisA001
builtin-variable-shadowing