Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cf-units] Ruff fixes #527

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Conversation

ukmo-ccbunney
Copy link
Contributor

🚀 Pull Request

Description

Note: This branch is currently based on qa_reresh_pre-commit-hooks branch, but will rebase on main once that branch is merged. First relevant commit is 2fc5e4f

Addresses failing Ruff tests, as described in #526

Not exhaustive, currently addresses following (see individual commits for details)

  • EM101 raw-string-in-exception
  • FLY002 Consider f-string instead of string join :
    • Added noqa exception for two instances asalternatives are not great:
      • f-strings don't really help (it would be a mess)
      • triple quotes preserve indentation
      • backslash at end of string for continuation is nasty and requires manually adding \n newline
  • FBT002 boolean-default-value-positional-argument.
  • All instances fixed with noqa: FBT002 as would affect API
  • D401 non-imperative-mood
  • D404 docstring-starts-with-this
  • A001 builtin-variable-shadowing

ukmo-ccbunney and others added 30 commits November 12, 2024 13:59
  - Required lots of additions to the Ruff ignore list
  - Extra additions to mypy ignore list
- Autofixes from Ruff linter
- Fixes from codespell
  - Removed some duplicate ruff ignores
  - Reorded some subsections
  - Added: `force-sort-within-sections = true`
  - Auto updated files resultig from above
  - file specific ignores
  - Trailing witespace
  - No neline at end of file
  - Some Ruff linting
- Add trailing / to mypy exclude paths
Added extra ignores in mypy for _udunits generated code
Re-added PY005 test to sp-repo-review ignore list.
  - All instances fixed with `noqa: FBT002` as  would affect API
  - f-strings don't really help (it would be a mess)
  - triple quotes preserve indentation
  - backslash at end of string for continuation is nasty and requires
	manually adding \n newlines
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 82.27848% with 14 lines in your changes missing coverage. Please review.

Project coverage is 58.46%. Comparing base (4ad25ba) to head (2f6736e).

Files with missing lines Patch % Lines
cf_units/__init__.py 81.81% 12 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #527      +/-   ##
==========================================
+ Coverage   58.41%   58.46%   +0.04%     
==========================================
  Files          62       62              
  Lines        6435     6447      +12     
  Branches     1150     1150              
==========================================
+ Hits         3759     3769      +10     
- Misses       2385     2387       +2     
  Partials      291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ukmo-ccbunney ukmo-ccbunney self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant