-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linting only runs on two files! #253
Comments
If we reinstate linting, I believe we can drop the restiction on having a single category. Our current rendering logic chooses the first category as the "primary" for the post header, but the post is actually visible under all given categories, which can make it easier to find when searching for a post from way back, so I believe that is a good thing. We will still need at least one category, and we should also check that all given categories are valid names from We should run this as a github workflow. |
Note that an alternative to multiple categories would be #197 to provide a keyword search. |
I have no objection to posts being in more than one category, as long as this is done sparingly! otherwise, this just becomes a form of tagging, as per the issue referenced above! |
Very true! We could of course set a limit on number of categories, and fail the build if folks are abusing the system. But just occasionally, it's difficult to choose between two different categories. |
Opened a PR to look at this - it's a bit big 😬
|
Whoops:
Turns out we are linting just two posts, because the glob pattern in lintPosts.js is this:
"*/_posts/**/*.{md,html}"
The pattern should be
"_posts/**/*.{md,markdown,html}"
And with that, predictably, we see a colossal amount of errors! However, all is not lost:
The text was updated successfully, but these errors were encountered: