add applicationLayout settings to ApplicationLayoutDto

[vferraro-scottlogic]

Background

The LayoutPersistenceManager interface has changed so that we are expecting GET/POST ApplicationLayout to return/take an ApplicationJSON object (it is actually wrapped in an object like such: { definition: ApplicationJSON } but we can remove this and just return an ApplicationJSON object). We need to change the ApplicationLayoutDto to reflect this change.

Work Required

• server
  • add settings to ApplicationLayoutDto
  • remove username from ApplicationLayoutDto
  • add settings to ApplicationLayout model
  • store applicationLayoutSettings in DB
• client
  • replace GetApplicationResponseDto with ApplicationJSON

Notes

• on the client side AppliationJSON is defined as follows:

interface ApplicationJSON {
  layout: LayoutJSON;
  settings?: ApplicationSettings;
}

interface ApplicationSettings {
  leftNav?: {
    activeTabIndex: number;
    expanded: boolean;
  };
}

[pling-scottlogic]

API contract to be modelled as two blobs of JSON for layout and settings. Tests to be written for contract.

[cfisher-scottlogic]

WIP on branch SLVUU-129-settings-in-dto

• TODOs in the code to fix failing tests
• add settings to ApplicationLayoutDto (not needed, keep it generic as one big JSON blob?)
• add settings to ApplicationLayout model (or not if generic)
• remove username from ApplicationLayoutDto
• replace GetApplicationResponseDto with ApplicationJSON
• make the cypress tests use the explicit types as defined in RemoteLayoutPersistenceManager
• server tests

Remember there's a new component ticket to take this from 'api tests' to 'tests for the remote layout persistence manager'