Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when attempting to read non-existant key in local storage #53

Closed
pling-scottlogic opened this issue Sep 20, 2023 · 1 comment

Comments

@pling-scottlogic
Copy link

Description

In LocalLayoutPersistenceManager, whenever we attempt to read a key from local storage which is not present, we immediately default to returning an empty array. We want to change this behaviour so that an exception is thrown, then caught and handled outside of the persistence manager.

Work Required

  • In LocalLayoutPersistenceManager, throw an appropriate exception whenever getLocalEntity returns undefined
  • Catch these exceptions outside of LocalLayoutPersistenceManager and handle appropriately (e.g. defaulting to an empty array)
@pling-scottlogic
Copy link
Author

Happy with the way LocalLayoutManager is currently handling this. Added a note to #27 to handle remote errors appropriately.

@pling-scottlogic pling-scottlogic closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants