Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make createLayoutRequestDTO' fields required #90

Open
vferraro-scottlogic opened this issue Oct 25, 2023 · 3 comments
Open

make createLayoutRequestDTO' fields required #90

vferraro-scottlogic opened this issue Oct 25, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@vferraro-scottlogic
Copy link

vferraro-scottlogic commented Oct 25, 2023

Background

Currently nothing is stopping us from sending a request which omits all the fields in metadata
Image

Work Required

  • all fields in metadata to be required except for screenshot (might have to create a new Dto if the current one is also used for updates)
@cfisher-scottlogic
Copy link

might have to create a new Dto if the current one is also used for updates

Why would updates not have the same constraints?

@vferraro-scottlogic
Copy link
Author

might have to create a new Dto if the current one is also used for updates

Why would updates not have the same constraints?

Actually yes. You can ignore that comment. We had a separate ticket for reworking the layout updates (either always send the whole entity or change to PATCH) and this will address that too.

@pling-scottlogic
Copy link

Testing in Postman, the API changes seem fine. There is a general bug with the remote implementation (#131) that is stopping me from testing from the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants