VUU86: Add tests for layout server #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion - Also amend DTOs to differentiate request/response data
7 tasks
Comment on lines
101
to
102
| // Generate a 404 if layout doesn't exist | ||
| layoutService.getLayout(id); |
There was a problem hiding this comment.
Do we want an exception to be thrown or do we want it to just silently do nothing?
There was a problem hiding this comment.
I'm inclined to say just logging it would be enough. DOn't see much value in informing the user - something has obviously gone wrong if this happens, so we should capture it, but its not going to affect the users experience.
# Conflicts: # layout-server/src/main/java/org/finos/vuu/layoutserver/controller/LayoutController.java # layout-server/src/main/java/org/finos/vuu/layoutserver/model/Layout.java # layout-server/src/main/java/org/finos/vuu/layoutserver/model/Metadata.java
pling-scottlogic
previously requested changes
Nov 1, 2023
layout-server/src/main/java/org/finos/vuu/layoutserver/controller/GlobalExceptionHandler.java
Outdated
Show resolved
Hide resolved
layout-server/src/main/java/org/finos/vuu/layoutserver/controller/GlobalExceptionHandler.java
Outdated
Show resolved
Hide resolved
layout-server/src/main/java/org/finos/vuu/layoutserver/model/Metadata.java
Outdated
Show resolved
Hide resolved
layout-server/src/main/java/org/finos/vuu/layoutserver/service/LayoutService.java
Outdated
Show resolved
Hide resolved
layout-server/src/test/java/org/finos/vuu/layoutserver/controller/LayoutControllerTest.java
Show resolved
Hide resolved
layout-server/src/test/java/org/finos/vuu/layoutserver/integration/LayoutIntegrationTest.java
Outdated
Show resolved
Hide resolved
layout-server/src/test/java/org/finos/vuu/layoutserver/integration/LayoutIntegrationTest.java
Show resolved
Hide resolved
layout-server/src/test/java/org/finos/vuu/layoutserver/integration/LayoutIntegrationTest.java
Outdated
Show resolved
Hide resolved
layout-server/src/test/java/org/finos/vuu/layoutserver/integration/LayoutIntegrationTest.java
Outdated
Show resolved
Hide resolved
layout-server/src/test/java/org/finos/vuu/layoutserver/integration/LayoutIntegrationTest.java
Outdated
Show resolved
Hide resolved
cfisher-scottlogic
changed the title
…Exists_returnsMetadata()`
…outHasChanged` - layout -> initialLayout - assertion that updatedLayout != initialLayout
I think so, what are you referring to in particular? The exception handling was all implemented in this PR because it was through writing the tests I uncovered what exceptions needed to be handled. That also meant some things needed to change to throw relevant exceptions to handle unhappy-path scenarios. Are there any alterations which aren't relevant to this?
I'm a bit test brain-dead. Can you suggest any unhappy paths I'm missing? I've tried to cover as many unhappy paths as possible with the integration tests, and possibly overlooked unit tests as they felt less cost effective. |
I didn't see any changes that I wasn't happy with, so I think we're good. Probably mostly exception handling and its fallout.
I think it's just the case when the delete throws an exception. |
cfisher-scottlogic
dismissed
pling-scottlogic’s stale review
Peter on AL, all comments resolved
pling-scottlogic
added a commit
that referenced
this pull request
Nov 21, 2023
* restore double quotes * layout-provider * layout-reducer * layout-view * palette * palette * placeholder * layout-view decomment * registry * rollback multi filter dropdown * stack * tabs * config wrapper * tools * utils * layout top level * revert flexbox layout change * restore lost semicolon * missing space * change action to a type union * Update README.md * Sync with Finos main * VUU-41 style fixes * VUU-41 rename css variable to --vuu * Manage layout persistence via interface (#55) * VUU25: Initialise module * VUU25: Basic Controller infrastructure * VUU25: Implement Layout & Metadata models * VUU25: Add OpenAPI docs (Swagger) * VUU25: Add basic H2 database * VUU25: Implement DTOs * VUU-27 interface to return promises * VUU25: Change server port and swagger URL * VUU25: Wire up Controller, Service and Repository for full implementation - Also amend DTOs to differentiate request/response data * VUU25: Implement model mapper to replace manual entity<->DTO conversion * VUU-47 add methods for loading and saving tempLayout * VUU-47 use loadLayoutById in LayoutList * VUU-47 remove unused files * VUU-47 update other examples to use new hook * VUU25: Fix one-to-one entity persistence issue * Calculated column (#882) * calculated column in settings, instrument search * additional mock data sources * instrument tiles * calculated column editing * measured-container * Row used columnMap rathe than column key * full keyboard nav for table * fix drag drop in column group headerr * use MeasuredContainer for Table List * table cell editing updates datasource * table editing * fix type issues * fix old background renderer * remove outdated import in showcase story * exclude PatternValidator from semgrep * add vuu tooltip component (#885) * VUU-47 improve naming * VUU-47 use placeholder in defaultLayout * VUU-47 update docs with new naming * remove duplicate CSS * VUU-47 fix layoutList styling * VUU-47 add loaded layouts to layout view * VUU25: Pluralise layout endpoint resource * VUU25: Amend annotations, javadocs, and updateLayout signature in the Controller * VUU25: Add javadocs to definition field in LayoutDTOs * VUU25: Remove no args constructor on entities * VUU25: Replace layoutRepository with metadataRepository in LayoutService.getMetadata * VUU25: Add date to create layout HTTP response body * VUU25: Introduce MetadataService * VUU-47 rename currentLayout to applicationLayout * VUU25: Create layout controller unit tests (backend) * VUU25: Create layout integration tests (backend) * VUU25: Add global exception handling to give appropriate HTTP responses * VUU25: Rename LayoutResponseDTO to GetLayoutResponseDTO * VUU25: Reformatting * VUU25: Make deleteLayout generate 404 if layout does not exist (backend) * VUU-47 make defaultLayout closeable and update features * VUU25: Downgrade Java 17 -> 11 and Springboot 3 -> 2 * VUU25: Change DB persistence from file to in-memory * VUU25: Fix issues caused by downgrading Java & Springboot * VUU25: Write description for layout-server pom.xml * VUU-27 interface to return promises * VUU-54: Validate IDs in LocalLayoutPersistenceManager * VUU-54: Mock get/saveLocalEntity * VUU-54: Refactor promises * VUU-54: Remove unnecessary asyncs * VUU-54: Use string union to distinguish layouts/metadata * VUU-54: Rename variables * VUU-54: Convert layout types to interfaces * VUU-54: Extract loadAndFilter method * VUU-54: Replace filter with find * VUU-54: Rename validateId variables * VUU-54: Change vars to lets * VUU-54: Update imports for consistency * VUU-54: Add comment to explain filter(Boolean) * VUU-54: Refactor tests * VUU-54: Extract expectError * VUU-54: Remove loadAndFilter method * VUU-54: Remove removeEntry method * VUU-52: Add E2E tests to CI * VUU-52: Use commit hash for cypress-io * VUU-52: Add comment to explain full SHA * VUU25: Implement interface for Metadata DTOs * VUU-47 rename imports * VUU-59 set up notification context * VUU-47 fix cypress test * Update vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts Co-authored-by: Cara <[email protected]> * VUU-47 remove unused import * VUU25: Create layout service unit tests (backend) * VUU25: Add test for transactional nature of LayoutService.createLayout() * VUU25: Remove unnecessary LayoutController unit tests * VUU25: Mock out model mapper in LayoutController tests * VUU25: Remove TODO * VUU25: Move 'updated date' logic from DTO to service for update layout requests * VUU-59 notifications with animation * VUU25: Move updateLayout logic from mapper in controller to setters in service * VUU-59 revert changes to imports * VUU25: Fix tests for recent changes in layout server - Update and delete layout in LayoutControllerTest and LayoutServiceTest * VUU25: Remove unnecessary autogenerated content - maven wrapper files - gitignore * VUU25: Make create layout (with a valid layout) integration test more robust * VUU-59 change toast timeout * VUU-59 change notificationType to enum * VUU-27 remotePersistenceManager implementation * VUU-27 https in baseUrl * VUU25: Increase max length of screenshot column * VUU25: Change create layout endpoint to return whole layout object * VUU25: Fix tests for new create layout response * VUU25: Simplify LayoutControllerTest test name - `getLayout_validIdAndLayoutExists_returnsLayout` -> `getLayout_layoutExists_returnsLayout` * VUU-59 improvements to example and add comments * VUU25: Fix tests for changed unidirectional Layout<->Metadata relationship * VUU-27 add cors config * VUU-27 improve error messages * VUU-27 improve error * VUU-27 add type for LayoutMetadataDto * VUU-27 remove redundant instantiation of persistenceManager * VUU-27 improvements to unit tests * VUU25: Implement layout server (#57) Implement the remote server implementation for layout management * VUU-27 make fetch method explicit for "GET" * VUU-70: Create resource for application layouts * VUU-70: Add integration tests * VUU-70: Add unit tests for controller * VUU-70: Fix service test * VUU-70: Extract constant for default layout file * VUU-70: Adjust whitespace * VUU-70: Use AttributeConverter for JsonNode * VUU-70: Remove DTO annotations * VUU-70: Rename method * VUU-70: Refactor getApplicationLayout * VUU-70: Standardise DTO casing * VUU-70: Return 500 on failed JSON read * VUU-70: Adjust exception handling * VUU-27 add check for date * VUU-27 allow BASE_URL env variable * VUU-70: Implement custom error responses * VUU25: Fix tests since merging in main with BaseMetadata * VUU25: Fix exception not being resolved due to invalid parameters * VUU-70: Update javadocs * VUU25: Add response body content message assertion for non-200 test requests * VUU-70: Revert application properties * VUU-27 test improvements * VUU25: Cleanup conflict resolution mistakes from merge commit * #900 disable failing test * Update check on viewport and context menu (#913) * remove reprecated Portal, fixes in COntextMenu * use woff2 font, fix portal * make sure ContextMenu always has theme attributes * type fixes * Tidy package and type issues (#914) * fix package references, type issues * add typescript config for correct auto import resolution * add Layout Management Provider to sample apps (#917) * add Layout Management Provider to sample apps * fix test dependencies * Drag drop provider (#918) * add DragDrop example, resume drag in DragProvider * full flow for remote drag * fix type issues * fix post rebase conflicts, type issues * ignore type issue in drag drop code for now, so packages build * Filterbar styling (#919) * improve the keyboards navigation in Toolbar * fix form control styling, uennecessaryb layout rerenders, table resize bug * make sure all table config setting changes are saved, style tweaks * calculated columns * fix dropdown width * fix width of combo in SaveLayout Panel * remove console.log * fix bug in OverflowContainer when orientation vertical * remove global error listener, leave this to cypress * move test schemas out of showcase (#920) * Update dependency electron to v22 [SECURITY] (#894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump vite, vitest versions to latest (#921) * Instrument picker (#923) * make instrument-picker more generic * refactor Table navigation, preparing for row highlighting * fix broken import paths * add empty inlined worker as vitext mocj fails otherwise * reinstate ignore for inlined-wotker so stub file doesn't get overwritten (#924) * VUU-27 refactor to not use appendAndPersist * VUU-70: Add DefaultApplicationLayoutLoader - Introduce DefaultApplicationLayoutLoader to lazily load JSON from a static file - Refactor service to use loader - Add integration test case for failure to load default - Rename static JSON files - Move JsonNodeConverter to utils package * VUU-70: Rename controller test methods * VUU25: Modify exception handling for deleteLayout * Merge branch 'main' of https://github.com/ScottLogic/finos-vuu into VUU-27-remote-layout-management * VUU-27 extract updatedLayout vars * VUU-27 add types for responses * VUU-89 make metadata and layout share ids * VUU-89 fix integration tests * VUU25: Improve non-200 response messages * VUU-70: Rename header key for username - Rename header key from 'user' to 'username' - Add integration tests for missing username * VUU-70: Remove POST endpoint * VUU-89 set metadata.id in Layout id setter and test improvements * Merge finos:main -> sl:main * #900 disable failing test * Update check on viewport and context menu (#913) * remove reprecated Portal, fixes in COntextMenu * use woff2 font, fix portal * make sure ContextMenu always has theme attributes * type fixes * Tidy package and type issues (#914) * fix package references, type issues * add typescript config for correct auto import resolution * Layout Management (#916) * fix vuu-filters types * drawer and dialog fix * drag drop flexbox editable * Update vuu-ui/packages/vuu-filters/src/filter-utils.ts Whitespace between guard clauses Co-authored-by: Luke Vincent <[email protected]> * layout header * restore double quotes * layout-provider * layout-reducer * layout-view * palette * palette * placeholder * layout-view decomment * registry * rollback multi filter dropdown * stack * tabs * config wrapper * tools * utils * layout top level * revert flexbox layout change * restore lost semicolon * missing space * change action to a type union * Update README.md * Sync with Finos main * VUU-41 style fixes * VUU-41 rename css variable to --vuu * Manage layout persistence via interface (#55) * VUU-27 interface to return promises * VUU-47 add methods for loading and saving tempLayout * VUU-47 use loadLayoutById in LayoutList * VUU-47 remove unused files * VUU-47 update other examples to use new hook * Calculated column (#882) * calculated column in settings, instrument search * additional mock data sources * instrument tiles * calculated column editing * measured-container * Row used columnMap rathe than column key * full keyboard nav for table * fix drag drop in column group headerr * use MeasuredContainer for Table List * table cell editing updates datasource * table editing * fix type issues * fix old background renderer * remove outdated import in showcase story * exclude PatternValidator from semgrep * add vuu tooltip component (#885) * VUU-47 improve naming * VUU-47 use placeholder in defaultLayout * VUU-47 update docs with new naming * remove duplicate CSS * VUU-47 fix layoutList styling * VUU-47 add loaded layouts to layout view * VUU-47 rename currentLayout to applicationLayout * VUU-47 make defaultLayout closeable and update features * VUU-27 interface to return promises * VUU-54: Validate IDs in LocalLayoutPersistenceManager * VUU-54: Mock get/saveLocalEntity * VUU-54: Refactor promises * VUU-54: Remove unnecessary asyncs * VUU-54: Use string union to distinguish layouts/metadata * VUU-54: Rename variables * VUU-54: Convert layout types to interfaces * VUU-54: Extract loadAndFilter method * VUU-54: Replace filter with find * VUU-54: Rename validateId variables * VUU-54: Change vars to lets * VUU-54: Update imports for consistency * VUU-54: Add comment to explain filter(Boolean) * VUU-54: Refactor tests * VUU-54: Extract expectError * VUU-54: Remove loadAndFilter method * VUU-54: Remove removeEntry method * VUU-52: Add E2E tests to CI * VUU-52: Use commit hash for cypress-io * VUU-52: Add comment to explain full SHA * VUU-47 rename imports * VUU-59 set up notification context * VUU-47 fix cypress test * Update vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts Co-authored-by: Cara <[email protected]> * VUU-47 remove unused import * VUU-59 notifications with animation * VUU-59 revert changes to imports * VUU-59 change toast timeout * VUU-59 change notificationType to enum * VUU-59 improvements to example and add comments --------- Co-authored-by: harryhartley <[email protected]> Co-authored-by: Luke Vincent <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: cfisher-scottlogic <[email protected]> Co-authored-by: Cara <[email protected]> Co-authored-by: Peter Ling <[email protected]> Co-authored-by: pling-scottlogic <[email protected]> Co-authored-by: heswell <[email protected]> * add Layout Management Provider to sample apps (#917) * add Layout Management Provider to sample apps * fix test dependencies * Drag drop provider (#918) * add DragDrop example, resume drag in DragProvider * full flow for remote drag * fix type issues * fix post rebase conflicts, type issues * ignore type issue in drag drop code for now, so packages build * Filterbar styling (#919) * improve the keyboards navigation in Toolbar * fix form control styling, uennecessaryb layout rerenders, table resize bug * make sure all table config setting changes are saved, style tweaks * calculated columns * fix dropdown width * fix width of combo in SaveLayout Panel * remove console.log * fix bug in OverflowContainer when orientation vertical * remove global error listener, leave this to cypress * move test schemas out of showcase (#920) * Update dependency electron to v22 [SECURITY] (#894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump vite, vitest versions to latest (#921) * Instrument picker (#923) * make instrument-picker more generic * refactor Table navigation, preparing for row highlighting * fix broken import paths * add empty inlined worker as vitext mocj fails otherwise * reinstate ignore for inlined-wotker so stub file doesn't get overwritten (#924) * disable basket functionality in showcase while we wait for full server (#925) * disable basket functionality in showcase while we wait for server implementation * remove console log * fix styling of main tabs during drag (#929) * wiring together calculated column pieces (#931) * wiring together calculated column pieces * remove logging * re-enable all tests * fix FilterTable resize bug (#932) * move table height fix to measured container (#933) * type fixes (#934) * final styling for calculated column input (#935) * connect filterbar to persistence (#936) * connect filterbar to persistence * skip test for missing TreeWalker finctionality until its there * final adjustments to table column header styling (#937) * move date generators to test data package (#938) * Bump postcss from 8.4.27 to 8.4.31 in /vuu-ui (#926) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.27 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.4.27...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * #850 added for functionality to the rpc service, not ready for the big time yet, but not far off. * #850 added ability to reference tables in separate modules. * #850 refactored simul module to take prices out to prices module * #850 refactored tableDefContainer to make it an implicit, otherwise it is re-used in the tests causing issues. * #850 found a bug with basket constituents, not resolved as of this commit. * #850 found a bug with basket constituents, not resolved as of this commit. * Update basket tables UI (#940) * update all basket tables, integrate basket server changes * filter basket tables when loading * connect cell editing * remove console log * fix newFeature story * remove console log * fix for dropdown width error * remove console.log * Fix faulty conflict resolutions --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: keikeicheung <[email protected]> Co-authored-by: heswell <[email protected]> Co-authored-by: Vasco <[email protected]> Co-authored-by: harryhartley <[email protected]> Co-authored-by: Luke Vincent <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Peter Ling <[email protected]> Co-authored-by: pling-scottlogic <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: chris <[email protected]> * VUU-89 add unit test for Layout * VUU-89 add id to response and service to return layout * VUU-70: Remove @Validated annotation * VUU-70: Make integration test constants private * VUU-89 sort imports and remove unneeded annotation * Merge finos:main -> sl:main * #900 disable failing test * Update check on viewport and context menu (#913) * remove reprecated Portal, fixes in COntextMenu * use woff2 font, fix portal * make sure ContextMenu always has theme attributes * type fixes * Tidy package and type issues (#914) * fix package references, type issues * add typescript config for correct auto import resolution * Layout Management (#916) * fix vuu-filters types * drawer and dialog fix * drag drop flexbox editable * Update vuu-ui/packages/vuu-filters/src/filter-utils.ts Whitespace between guard clauses Co-authored-by: Luke Vincent <[email protected]> * layout header * restore double quotes * layout-provider * layout-reducer * layout-view * palette * palette * placeholder * layout-view decomment * registry * rollback multi filter dropdown * stack * tabs * config wrapper * tools * utils * layout top level * revert flexbox layout change * restore lost semicolon * missing space * change action to a type union * Update README.md * Sync with Finos main * VUU-41 style fixes * VUU-41 rename css variable to --vuu * Manage layout persistence via interface (#55) * VUU-27 interface to return promises * VUU-47 add methods for loading and saving tempLayout * VUU-47 use loadLayoutById in LayoutList * VUU-47 remove unused files * VUU-47 update other examples to use new hook * Calculated column (#882) * calculated column in settings, instrument search * additional mock data sources * instrument tiles * calculated column editing * measured-container * Row used columnMap rathe than column key * full keyboard nav for table * fix drag drop in column group headerr * use MeasuredContainer for Table List * table cell editing updates datasource * table editing * fix type issues * fix old background renderer * remove outdated import in showcase story * exclude PatternValidator from semgrep * add vuu tooltip component (#885) * VUU-47 improve naming * VUU-47 use placeholder in defaultLayout * VUU-47 update docs with new naming * remove duplicate CSS * VUU-47 fix layoutList styling * VUU-47 add loaded layouts to layout view * VUU-47 rename currentLayout to applicationLayout * VUU-47 make defaultLayout closeable and update features * VUU-27 interface to return promises * VUU-54: Validate IDs in LocalLayoutPersistenceManager * VUU-54: Mock get/saveLocalEntity * VUU-54: Refactor promises * VUU-54: Remove unnecessary asyncs * VUU-54: Use string union to distinguish layouts/metadata * VUU-54: Rename variables * VUU-54: Convert layout types to interfaces * VUU-54: Extract loadAndFilter method * VUU-54: Replace filter with find * VUU-54: Rename validateId variables * VUU-54: Change vars to lets * VUU-54: Update imports for consistency * VUU-54: Add comment to explain filter(Boolean) * VUU-54: Refactor tests * VUU-54: Extract expectError * VUU-54: Remove loadAndFilter method * VUU-54: Remove removeEntry method * VUU-52: Add E2E tests to CI * VUU-52: Use commit hash for cypress-io * VUU-52: Add comment to explain full SHA * VUU-47 rename imports * VUU-59 set up notification context * VUU-47 fix cypress test * Update vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts Co-authored-by: Cara <[email protected]> * VUU-47 remove unused import * VUU-59 notifications with animation * VUU-59 revert changes to imports * VUU-59 change toast timeout * VUU-59 change notificationType to enum * VUU-59 improvements to example and add comments --------- Co-authored-by: harryhartley <[email protected]> Co-authored-by: Luke Vincent <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: cfisher-scottlogic <[email protected]> Co-authored-by: Cara <[email protected]> Co-authored-by: Peter Ling <[email protected]> Co-authored-by: pling-scottlogic <[email protected]> Co-authored-by: heswell <[email protected]> * add Layout Management Provider to sample apps (#917) * add Layout Management Provider to sample apps * fix test dependencies * Drag drop provider (#918) * add DragDrop example, resume drag in DragProvider * full flow for remote drag * fix type issues * fix post rebase conflicts, type issues * ignore type issue in drag drop code for now, so packages build * Filterbar styling (#919) * improve the keyboards navigation in Toolbar * fix form control styling, uennecessaryb layout rerenders, table resize bug * make sure all table config setting changes are saved, style tweaks * calculated columns * fix dropdown width * fix width of combo in SaveLayout Panel * remove console.log * fix bug in OverflowContainer when orientation vertical * remove global error listener, leave this to cypress * move test schemas out of showcase (#920) * Update dependency electron to v22 [SECURITY] (#894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump vite, vitest versions to latest (#921) * Instrument picker (#923) * make instrument-picker more generic * refactor Table navigation, preparing for row highlighting * fix broken import paths * add empty inlined worker as vitext mocj fails otherwise * reinstate ignore for inlined-wotker so stub file doesn't get overwritten (#924) * disable basket functionality in showcase while we wait for full server (#925) * disable basket functionality in showcase while we wait for server implementation * remove console log * fix styling of main tabs during drag (#929) * wiring together calculated column pieces (#931) * wiring together calculated column pieces * remove logging * re-enable all tests * fix FilterTable resize bug (#932) * move table height fix to measured container (#933) * type fixes (#934) * final styling for calculated column input (#935) * connect filterbar to persistence (#936) * connect filterbar to persistence * skip test for missing TreeWalker finctionality until its there * final adjustments to table column header styling (#937) * move date generators to test data package (#938) * Bump postcss from 8.4.27 to 8.4.31 in /vuu-ui (#926) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.27 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.4.27...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * #850 added for functionality to the rpc service, not ready for the big time yet, but not far off. * #850 added ability to reference tables in separate modules. * #850 refactored simul module to take prices out to prices module * #850 refactored tableDefContainer to make it an implicit, otherwise it is re-used in the tests causing issues. * #850 found a bug with basket constituents, not resolved as of this commit. * #850 found a bug with basket constituents, not resolved as of this commit. * Update basket tables UI (#940) * update all basket tables, integrate basket server changes * filter basket tables when loading * connect cell editing * remove console log * fix newFeature story * remove console log * fix for dropdown width error * remove console.log * basket workflow (#941) * Fix faulty conflict resolutions --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: keikeicheung <[email protected]> Co-authored-by: heswell <[email protected]> Co-authored-by: Vasco <[email protected]> Co-authored-by: harryhartley <[email protected]> Co-authored-by: Luke Vincent <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Peter Ling <[email protected]> Co-authored-by: pling-scottlogic <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: chris <[email protected]> * VUU86: Add tests for layout server (#68) * merge main in VUU-70 * VUU-70 improve exception handling and clean-up * VUU-70 fix comment * VUU-70 remove helper method * Update layout-server/src/main/java/org/finos/vuu/layoutserver/repository/MetadataRepository.java Co-authored-by: Cara <[email protected]> * Update layout-server/src/main/java/org/finos/vuu/layoutserver/model/Layout.java Co-authored-by: Cara <[email protected]> * VUU-89 re-add unit test * VUU-71: Interact with server for application layouts * VUU-71: Extract app layout in remote manager * VUU-71: Rename variable * VUU-71: Apply auto formatting * Sync mains (pull) (#106) * #900 disable failing test * Update check on viewport and context menu (#913) * remove reprecated Portal, fixes in COntextMenu * use woff2 font, fix portal * make sure ContextMenu always has theme attributes * type fixes * Tidy package and type issues (#914) * fix package references, type issues * add typescript config for correct auto import resolution * Layout Management (#916) * fix vuu-filters types * drawer and dialog fix * drag drop flexbox editable * Update vuu-ui/packages/vuu-filters/src/filter-utils.ts Whitespace between guard clauses Co-authored-by: Luke Vincent <[email protected]> * layout header * restore double quotes * layout-provider * layout-reducer * layout-view * palette * palette * placeholder * layout-view decomment * registry * rollback multi filter dropdown * stack * tabs * config wrapper * tools * utils * layout top level * revert flexbox layout change * restore lost semicolon * missing space * change action to a type union * Update README.md * Sync with Finos main * VUU-41 style fixes * VUU-41 rename css variable to --vuu * Manage layout persistence via interface (#55) * VUU-27 interface to return promises * VUU-47 add methods for loading and saving tempLayout * VUU-47 use loadLayoutById in LayoutList * VUU-47 remove unused files * VUU-47 update other examples to use new hook * Calculated column (#882) * calculated column in settings, instrument search * additional mock data sources * instrument tiles * calculated column editing * measured-container * Row used columnMap rathe than column key * full keyboard nav for table * fix drag drop in column group headerr * use MeasuredContainer for Table List * table cell editing updates datasource * table editing * fix type issues * fix old background renderer * remove outdated import in showcase story * exclude PatternValidator from semgrep * add vuu tooltip component (#885) * VUU-47 improve naming * VUU-47 use placeholder in defaultLayout * VUU-47 update docs with new naming * remove duplicate CSS * VUU-47 fix layoutList styling * VUU-47 add loaded layouts to layout view * VUU-47 rename currentLayout to applicationLayout * VUU-47 make defaultLayout closeable and update features * VUU-27 interface to return promises * VUU-54: Validate IDs in LocalLayoutPersistenceManager * VUU-54: Mock get/saveLocalEntity * VUU-54: Refactor promises * VUU-54: Remove unnecessary asyncs * VUU-54: Use string union to distinguish layouts/metadata * VUU-54: Rename variables * VUU-54: Convert layout types to interfaces * VUU-54: Extract loadAndFilter method * VUU-54: Replace filter with find * VUU-54: Rename validateId variables * VUU-54: Change vars to lets * VUU-54: Update imports for consistency * VUU-54: Add comment to explain filter(Boolean) * VUU-54: Refactor tests * VUU-54: Extract expectError * VUU-54: Remove loadAndFilter method * VUU-54: Remove removeEntry method * VUU-52: Add E2E tests to CI * VUU-52: Use commit hash for cypress-io * VUU-52: Add comment to explain full SHA * VUU-47 rename imports * VUU-59 set up notification context * VUU-47 fix cypress test * Update vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts Co-authored-by: Cara <[email protected]> * VUU-47 remove unused import * VUU-59 notifications with animation * VUU-59 revert changes to imports * VUU-59 change toast timeout * VUU-59 change notificationType to enum * VUU-59 improvements to example and add comments --------- Co-authored-by: harryhartley <[email protected]> Co-authored-by: Luke Vincent <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: cfisher-scottlogic <[email protected]> Co-authored-by: Cara <[email protected]> Co-authored-by: Peter Ling <[email protected]> Co-authored-by: pling-scottlogic <[email protected]> Co-authored-by: heswell <[email protected]> * add Layout Management Provider to sample apps (#917) * add Layout Management Provider to sample apps * fix test dependencies * Drag drop provider (#918) * add DragDrop example, resume drag in DragProvider * full flow for remote drag * fix type issues * fix post rebase conflicts, type issues * ignore type issue in drag drop code for now, so packages build * Filterbar styling (#919) * improve the keyboards navigation in Toolbar * fix form control styling, uennecessaryb layout rerenders, table resize bug * make sure all table config setting changes are saved, style tweaks * calculated columns * fix dropdown width * fix width of combo in SaveLayout Panel * remove console.log * fix bug in OverflowContainer when orientation vertical * remove global error listener, leave this to cypress * move test schemas out of showcase (#920) * Update dependency electron to v22 [SECURITY] (#894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump vite, vitest versions to latest (#921) * Instrument picker (#923) * make instrument-picker more generic * refactor Table navigation, preparing for row highlighting * fix broken import paths * add empty inlined worker as vitext mocj fails otherwise * reinstate ignore for inlined-wotker so stub file doesn't get overwritten (#924) * disable basket functionality in showcase while we wait for full server (#925) * disable basket functionality in showcase while we wait for server implementation * remove console log * fix styling of main tabs during drag (#929) * wiring together calculated column pieces (#931) * wiring together calculated column pieces * remove logging * re-enable all tests * fix FilterTable resize bug (#932) * move table height fix to measured container (#933) * type fixes (#934) * final styling for calculated column input (#935) * connect filterbar to persistence (#936) * connect filterbar to persistence * skip test for missing TreeWalker finctionality until its there * final adjustments to table column header styling (#937) * move date generators to test data package (#938) * Bump postcss from 8.4.27 to 8.4.31 in /vuu-ui (#926) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.27 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.4.27...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * #850 added for functionality to the rpc service, not ready for the big time yet, but not far off. * #850 added ability to reference tables in separate modules. * #850 refactored simul module to take prices out to prices module * #850 refactored tableDefContainer to make it an implicit, otherwise it is re-used in the tests causing issues. * #850 found a bug with basket constituents, not resolved as of this commit. * #850 found a bug with basket constituents, not resolved as of this commit. * Update basket tables UI (#940) * update all basket tables, integrate basket server changes * filter basket tables when loading * connect cell editing * remove console log * fix newFeature story * remove console log * fix for dropdown width error * remove console.log * basket workflow (#941) * Login panel (#942) * login panel * WIP * tidy up type issues etc * import fixes * remove deprecated example * #944 Added fix for threading related issue in ViewPortContainer.scala when change was called. * #944 Reduced logging * Switch UI to new Theme (#943) * remove sample app * rename basket trading app to sample-app * fix broken inmports * fix bugs persistning table settings * 862 create a basketdesign table that represents the specific instance of a basket that we are modifying it will be based on a basket entry but can be customized to what the user needs (#948) * #862 Fixed test versions to abstract out clock. * #862 Added Viewport scoped rpc service to test. * #862 Added ability to edit baskets join service. * Fix minor UI issues (#949) * fix UI dataTable issue - bugs after resize A column resize operation populates the ColumnState state value. From this point on columnState shadows modelColumns so subsequent changes to modelColumns are not rendered. * enable custom editors for cell renderers Column Settings Panel allows a custom renderer to be selected. Some renderers will have settings of their own. This enables editors form those settings to be made available. * fix type issue * update baskets used in showcase examples to match server tables (#950) * add initial support for columns backed by lookup tables (#951) * move basket data generation into simulated vuu module to pave way for rpc support * add updater for prices, insert for array data source * create Table for test data in modules * fix scrolling issue in table when focusing edit fields * add initial support for table columns backed by lookup tables * wire table cell editing to server calls (#953) * Schema load sequence (#955) * cache table meta requests with promise to avoid multiple server requests * ensure table meta is loaded before client is notified of subcribe table meta for all tables was being requested from server every time any hook asked for the table data. This was happening twice at startup. Now we cache the metadata. If we didn't have table meta at point where CREATE_VP_SUCCESS was handled, we notified client anyway. This caused tables to be rendered with no type information, so alignment was wrong on numerics. * fix all data tests * Merge persistence manager generator approaches * Fix duplicated NavigationStyle export in `TableNext.examples.tsx` --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: keikeicheung <[email protected]> Co-authored-by: heswell <[email protected]> Co-authored-by: Vasco <[email protected]> Co-authored-by: harryhartley <[email protected]> Co-authored-by: Luke Vincent <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Peter Ling <[email protected]> Co-authored-by: pling-scottlogic <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: chris <[email protected]> Co-authored-by: chrisjstevo <[email protected]> * VUU80: Refactor Dialog styling to fix multiple components (#100) - Header alignment - Border - Fonts - 'Close' button - Body padding * Sync mains (pull) (#107) * #900 disable failing test * Update check on viewport and context menu (#913) * remove reprecated Portal, fixes in COntextMenu * use woff2 font, fix portal * make sure ContextMenu always has theme attributes * type fixes * Tidy package and type issues (#914) * fix package references, type issues * add typescript config for correct auto import resolution * Layout Management (#916) * fix vuu-filters types * drawer and dialog fix * drag drop flexbox editable * Update vuu-ui/packages/vuu-filters/src/filter-utils.ts Whitespace between guard clauses Co-authored-by: Luke Vincent <[email protected]> * layout header * restore double quotes * layout-provider * layout-reducer * layout-view * palette * palette * placeholder * layout-view decomment * registry * rollback multi filter dropdown * stack * tabs * config wrapper * tools * utils * layout top level * revert flexbox layout change * restore lost semicolon * missing space * change action to a type union * Update README.md * Sync with Finos main * VUU-41 style fixes * VUU-41 rename css variable to --vuu * Manage layout persistence via interface (#55) * VUU-27 interface to return promises * VUU-47 add methods for loading and saving tempLayout * VUU-47 use loadLayoutById in LayoutList * VUU-47 remove unused files * VUU-47 update other examples to use new hook * Calculated column (#882) * calculated column in settings, instrument search * additional mock data sources * instrument tiles * calculated column editing * measured-container * Row used columnMap rathe than column key * full keyboard nav for table * fix drag drop in column group headerr * use MeasuredContainer for Table List * table cell editing updates datasource * table editing * fix type issues * fix old background renderer * remove outdated import in showcase story * exclude PatternValidator from semgrep * add vuu tooltip component (#885) * VUU-47 improve naming * VUU-47 use placeholder in defaultLayout * VUU-47 update docs with new naming * remove duplicate CSS * VUU-47 fix layoutList styling * VUU-47 add loaded layouts to layout view * VUU-47 rename currentLayout to applicationLayout * VUU-47 make defaultLayout closeable and update features * VUU-27 interface to return promises * VUU-54: Validate IDs in LocalLayoutPersistenceManager * VUU-54: Mock get/saveLocalEntity * VUU-54: Refactor promises * VUU-54: Remove unnecessary asyncs * VUU-54: Use string union to distinguish layouts/metadata * VUU-54: Rename variables * VUU-54: Convert layout types to interfaces * VUU-54: Extract loadAndFilter method * VUU-54: Replace filter with find * VUU-54: Rename validateId variables * VUU-54: Change vars to lets * VUU-54: Update imports for consistency * VUU-54: Add comment to explain filter(Boolean) * VUU-54: Refactor tests * VUU-54: Extract expectError * VUU-54: Remove loadAndFilter method * VUU-54: Remove removeEntry method * VUU-52: Add E2E tests to CI * VUU-52: Use commit hash for cypress-io * VUU-52: Add comment to explain full SHA * VUU-47 rename imports * VUU-59 set up notification context * VUU-47 fix cypress test * Update vuu-ui/packages/vuu-layout/src/layout-persistence/LayoutPersistenceManager.ts Co-authored-by: Cara <[email protected]> * VUU-47 remove unused import * VUU-59 notifications with animation * VUU-59 revert changes to imports * VUU-59 change toast timeout * VUU-59 change notificationType to enum * VUU-59 improvements to example and add comments --------- Co-authored-by: harryhartley <[email protected]> Co-authored-by: Luke Vincent <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: cfisher-scottlogic <[email protected]> Co-authored-by: Cara <[email protected]> Co-authored-by: Peter Ling <[email protected]> Co-authored-by: pling-scottlogic <[email protected]> Co-authored-by: heswell <[email protected]> * add Layout Management Provider to sample apps (#917) * add Layout Management Provider to sample apps * fix test dependencies * Drag drop provider (#918) * add DragDrop example, resume drag in DragProvider * full flow for remote drag * fix type issues * fix post rebase conflicts, type issues * ignore type issue in drag drop code for now, so packages build * Filterbar styling (#919) * improve the keyboards navigation in Toolbar * fix form control styling, uennecessaryb layout rerenders, table resize bug * make sure all table config setting changes are saved, style tweaks * calculated columns * fix dropdown width * fix width of combo in SaveLayout Panel * remove console.log * fix bug in OverflowContainer when orientation vertical * remove global error listener, leave this to cypress * move test schemas out of showcase (#920) * Update dependency electron to v22 [SECURITY] (#894) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * bump vite, vitest versions to latest (#921) * Instrument picker (#923) * make instrument-picker more generic * refactor Table navigation, preparing for row highlighting * fix broken import paths * add empty inlined worker as vitext mocj fails otherwise * reinstate ignore for inlined-wotker so stub file doesn't get overwritten (#924) * disable basket functionality in showcase while we wait for full server (#925) * disable basket functionality in showcase while we wait for server implementation * remove console log * fix styling of main tabs during drag (#929) * wiring together calculated column pieces (#931) * wiring together calculated column pieces * remove logging * re-enable all tests * fix FilterTable resize bug (#932) * move table height fix to measured container (#933) * type fixes (#934) * final styling for calculated column input (#935) * connect filterbar to persistence (#936) * connect filterbar to persistence * skip test for missing TreeWalker finctionality until its there * final adjustments to table column header styling (#937) * move date generators to test data package (#938) * Bump postcss from 8.4.27 to 8.4.31 in /vuu-ui (#926) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.27 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.4.27...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * #850 added for functionality to the rpc service, not ready for the big time yet, but not far off. * #850 added ability to reference tables in separate modules. * #850 refactored simul module to take prices out to prices module * #850 refactored tableDefContainer to make it an implicit, otherwise it is re-used in the tests causing issues. * #850 found a bug with basket constituents, not resolved as of this commit. * #850 found a bug with basket constituents, not resolved as of this commit. * Update basket tables UI (#940) * update all basket tables, integrate basket server changes * filter basket tables when loading * connect cell editing * remove console log * fix newFeature story * remove console log * fix for dropdown width error * remove console.log * basket workflow (#941) * Login panel (#942) * login panel * WIP * tidy up type issues etc * import fixes * remove deprecated example * #944 Added fix for threading related issue in ViewPortContainer.scala when change was called. * #944 Reduced logging * Switch UI to new Theme (#943) * remove sample app * rename basket trading app to sample-app * fix broken inmports * fix bugs persistning table settings * 862 create a basketdesign table that represents the specific instance of a basket that we are modifying it will be based on a basket entry but can be customized to what the user needs (#948) * #862 Fixed test versions to abstract out clock. * #862 Added Viewport scoped rpc service to test. * #862 Added ability to edit baskets join service. * Fix minor UI issues (#949) * fix UI dataTable issue - bugs after resize A column resize operation populates the ColumnState state value. From this point on columnState shadows modelColumns so subsequent changes to modelColumns are not rendered. * enable custom editors for cell renderers Column Settings Panel allows a custom renderer to be selected. Some renderers will have settings of their own. This enables editors form those settings to be made available. * fix type issue * update baskets used in showcase examples to match server tables (#950) * add initial support for columns backed by lookup tables (#951) * move basket data generation into simulated vuu module to pave way for rpc support * add updater for prices, insert for array data source * create Table for test data in modules * fix scrolling issue in table when focusing edit fields * add initial support for table columns backed by lookup tables * wire table cell editing to server calls (#953) * Schema load sequence (#955) * cache table meta requests with promise to avoid multiple server requests * ensure table meta is loaded before client is notified of subcribe table meta for all tables was being requested from server every time any hook asked for the table data. This was happening twice at startup. Now we cache the metadata. If we didn't have table meta at point where CREATE_VP_SUCCESS was handled, we notified client anyway. This caused tables to be rendered with no type information, so alignment was wrong on numerics. * fix all data tests * Issue 850 added the first example module test for rpc services (#954) * #850 Refactored example code so that simulation is in its own module * #850 Refactored example code into its own module * #850 updated documentation * #850 organized imports * #850 added first consumer test outline * #850 added ability to create viewport in test easily * #850 added ability to create viewport in test easily * #850 added first example working test calling viewport Rpc call. * #850 renamed test case. * #850 Added example flow for baskets * #850 Added additional example for editRowAction * #850 Added additional methods for editable example. * #850 Added additional methods for editable example. * #850 Added more functionality to the demo basket app. * #850 Added thorough test of basket functionality. * #850 Fixed test assert which accidentally changed contract in test. * #850 Fixed test assert which accidentally changed contract in test. * #850 Fixed test assert which accidentally changed contract in test. * #850 fixed the bad pom definition. * #850 deleted duplicate and not required config and updated semgrep. * Release 0.9.20 beta (#956) * [maven-release-plugin] prepare release vuu-parent-0.9.20-beta * [maven-release-plugin] prepare for next development iteration --------- Co-authored-by: GitHub Actions <[email protected]> * #957 added all projects to release build. (#960) * #957 added all projects to release build. * #957 added all projects to release build. * #957 added all projects to release build. * Release 0.9.33 beta (#961) * [maven-release-plugin] prepare release vuu-parent-0.9.33-beta * [maven-release-plugin] prepare for next development iteration --------- Co-authored-by: GitHub Actions <[email protected]> * #957 fixed issue with javadoc. (#963) * Release 0.9.35 beta (#964) * [maven-release-plugin] prepare release vuu-parent-0.9.35-beta * [maven-release-plugin] prepare for next development iteration --------- Co-authored-by: GitHub Actions <[email protected]> * enable context menu on basket constituents (#965) * fix behaviour in baskets module in data-test * fix pinned column rendering gap * enable context menu in basket constituent table in basket feature * remove console log * Fix conflict resolutions --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: keikeicheung <[email protected]> Co-authored-by: heswell <[email protected]> Co-authored-by: Vasco <[email protected]> Co-authored-by: harryhartley <[email protected]> Co-authored-by: Luke Vincent <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Peter Ling <[email protected]> Co-authored-by: pling-scottlogic <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: chris <[email protected]> Co-authored-by: chrisjstevo <[email protected]> Co-authored-by: GitHub Actions <[email protected]> * VUU-333: Post-merge fix * VUU-96: Convert Date to LocalDate * VUU-81 layout definition as ObjectNode * VUU-81 remove unused imports * VUU-81 remove redundant annotation and tidy up * VUU-81 make const naming consistent in unit tests and add comments * VUU-81 remove stringify() for definition in POST * VUU-81 improve naming in test * SLVUU-27: Add allowed origins to CORS config * SLVUU-113: Add `process.env.LOCAL` flag to `esbuild.mjs` (#116) * SLVUU-113: Add `process.env.LOCAL` flag to `esbuild.mjs` * SLVUU-113: Remove runtime null coalescence of envar * SLVUU-113: Add BASE_URL envar to sample-app's esbuild.mjs * SLVUU-113: Add BASE_URL envar to showcase's vite.config.js --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: harryhartley <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: Joe Dunleavy <[email protected]> Co-authored-by: cfisher-scottlogic <[email protected]> Co-authored-by: Cara <[email protected]> Co-authored-by: vferraro-scottlogic <[email protected]> Co-authored-by: Vasco <[email protected]> Co-authored-by: heswell <[email protected]> Co-authored-by: keikeicheung <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Luke Vincent <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: chris <[email protected]> Co-authored-by: chrisjstevo <[email protected]> Co-authored-by: GitHub Actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #57.
The layout server implementation PR is here. This is the separate PR for all of the related tests.
It's definitely worth thinking about whether the edge cases are giving us the desired responses.
Change List
LayoutControllerTesttestsLayoutServiceTesttestsLayoutIntegrationTesttests (tests endpoints with fully contextualized Spring server)