tab name now includes filename #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OiNutter
reviewed
Aug 6, 2021
| } | ||
| }, | ||
| { | ||
| key: "save-as", |
There was a problem hiding this comment.
Rather than having 2 similar icons and the menu getting cluttered I think it would be nicer to use the menu button functionality to essentially make it a drop down. See the second IconButton example here
There was a problem hiding this comment.
I think that's a good call, but I'd prefer to leave that until we have a bit more of the functionality fleshed out then look at the UI in its entirety.
Currently the app is a bit 'button heavy', similar to the current KDB Studio:
Whereas, comparing to VS Code itself, most of those functions are relegated to menus and hotkeys. People know where to look for load / save etc ...
ColinEberhardt
force-pushed
the
updated-save-load-behaviour
branch
from
7242ca8 to
9010d21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added filename to the tab, and expanded functionality to provide load / save and save-as behaviour:
Note, the previous version had a bug, when a file was opened ipcMain raised an event that was handled by all editor windows, so all would update to the new file contents. Updated to use
ipcRenderer.invokeandipcMain.handleinstead.