Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show error if we fail to reset defences #714

Open
Tracked by #640
gsproston-scottlogic opened this issue Dec 21, 2023 · 0 comments · May be fixed by #927
Open
Tracked by #640

Show error if we fail to reset defences #714

gsproston-scottlogic opened this issue Dec 21, 2023 · 0 comments · May be fixed by #927
Labels
bug Something isn't working frontend Requires work on the frontend good first issue Simple issue triage New tickets to be checked by the maintainers
Milestone
Review and close ...

Comments

@gsproston-scottlogic
Copy link
Contributor

gsproston-scottlogic commented Dec 21, 2023 •
edited
Loading

Bug report

Description

Pressing the 'reset' button will always show the confirmation message, even if the reset HTTP request fails. We should show an error instead.

Reproduction steps

Steps to reproduce the behaviour:

  1. Don't run the backend
  2. So to sandbox mode
  3. Expand a configurable defence, e.g. character limit
  4. Press the reset button
  5. Confirmation shown

Expected behaviour

Show an error if the reset fails.

Screenshots

image

Software (please complete the following information):

  • Browser: Edge

Acceptance criteria

GIVEN the backend is down
WHEN the reset button is pressed
THEN an error message is shown
Closed
4 tasks
@gsproston-scottlogic gsproston-scottlogic changed the title Reset defence configurations still shows a message saying 'defence configured successfully' - Just disable the button. Show error message on timeout instead. Show error if we fail to reset defences Dec 21, 2023
@gsproston-scottlogic gsproston-scottlogic added bug Something isn't working frontend Requires work on the frontend good first issue Simple issue triage New tickets to be checked by the maintainers labels Dec 21, 2023
@gsproston-scottlogic gsproston-scottlogic removed the triage New tickets to be checked by the maintainers label Jan 4, 2024
@pmarsh-scottlogic pmarsh-scottlogic added this to the Error Handling milestone Jan 19, 2024
@kclark-scottlogic kclark-scottlogic added the triage New tickets to be checked by the maintainers label Mar 7, 2024
@calummcgowan calummcgowan linked a pull request Nov 8, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend Requires work on the frontend good first issue Simple issue triage New tickets to be checked by the maintainers
Projects
None yet
Milestone
Review and close off error handling
Development

Successfully merging a pull request may close this issue.

714: Show error is we fail to reset defences calummcgowan/prompt-injection
3 participants
@kclark-scottlogic @gsproston-scottlogic @pmarsh-scottlogic