Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotune Peak Count Not Incrementing Despite Valid Oscillations #268

Open
qukla1000 opened this issue Dec 6, 2024 · 0 comments
Open

Autotune Peak Count Not Incrementing Despite Valid Oscillations #268

qukla1000 opened this issue Dec 6, 2024 · 0 comments

Comments

@qukla1000
Copy link

Describe the bug
The autotune_peak_count remains at 0 despite clear and sufficient oscillations being observed, as well as the autotune_buffer_full reaching 1 (100%). The autotune_status correctly detects oscillation phases such as relay step down. The issue occurs consistently across all smart thermostats configured in Home Assistant. This behavior persists regardless of calibration durations (tested with both 8-hour and 12-hour periods).

To Reproduce

Steps to reproduce the behavior:

Configure a Smart Thermostat (PID) in Home Assistant with the provided example configuration.
Set lookback to 8 or 12 hours and ensure oscillations are present.
Observe the behavior of autotune_peak_count during the calibration process.
The value of autotune_peak_count remains at 0 despite the buffer being full and oscillations clearly visible.
Expected behavior
The autotune_peak_count should increment as valid oscillations are detected during the autotuning process.

Screenshots
Below is an example graph showcasing the issue:
image
image
image

Example Configuration

  - platform: smart_thermostat
    name: Wiatrołap Podłoga PID6 
    unique_id: wiatrolap_podloga_PID6  
    heater: switch.wiatrolap_podloga  
    target_sensor: sensor.wiatrolap_podloga  
    precision: 0.1 
    min_temp: 10 
    max_temp: 42 
    ac_mode: False
    target_temp: 20 
    min_cycle_duration: 00:02:35 
    keep_alive: 
      seconds: 10 
    noiseband: 0.2  
    lookback: 08:00:00
    autotune: "no-overshoot"    
    debug: true

Environment
Home Assistant Version: 2024.9.3
Smart Thermostat (PID) Version: 2024.11.0-alpha1

Additional Context
The issue is consistent across multiple thermostats and persists regardless of different tuning parameters or system configurations. The attached graph illustrates significant oscillations, but no peaks are counted during the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant