Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitUntil on BPSeasideWebDriverTestCase #13

Open
LesageYann opened this issue Jan 22, 2018 · 1 comment
Open

waitUntil on BPSeasideWebDriverTestCase #13

LesageYann opened this issue Jan 22, 2018 · 1 comment

Comments

@LesageYann
Copy link

Hi,

I have see two interesting functions :
BPSeasideWebDriverTestCase >> waitUntil:checkEvery:timeoutAfter:
BPSeasideWebDriverTestCase >> waitUntil:checkEvery:timeoutAfter:with:

Why don't move this on parent BPSeasideWebDriverTestCase ?

@Rinzwind
Copy link
Member

Rinzwind commented Feb 2, 2018

You mean the waitUntil:* methods in BPParasolSelfTestCase? It does look like those could be pulled up to BPSeasideWebDriverTestCase or BPWebDriverTestCase.

Though we should instead, perhaps, implement the “waiting” framework that the Java reference implementation has. The WebDriver website has a small example that demonstrates the basics (it makes use of WebDriver.until and ExpectedConditions.presenceOfElementLocated; neither class currently has a counterpart in Parasol).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants