Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

advertise_objects.repy needs to be re-written and enhanced #1387

Open
choksi81 opened this issue May 25, 2014 · 0 comments
Open

advertise_objects.repy needs to be re-written and enhanced #1387

choksi81 opened this issue May 25, 2014 · 0 comments
Assignees
@aaaaalbert
Labels
C: seattlelib P: major T: enhancement

Comments

@choksi81
Copy link

The current advertise_objects.repy that provides a LookupCache object (for caching result when frequent lookup is required) and AdvertisePipe object which advertises the (key,val) at certain intervals.

This file needs to be updated to combine the two objects so we have one object that performs both task. This will allow us to do quick lookups of local advertisements. Furthermore we need to make it conform to advertise.repy, so they accept the same arguments.
choksi81 pushed a commit that referenced this issue May 25, 2014
A streamlined version of advertise_objects.repy for #1387.
6a86ecc
choksi81 pushed a commit that referenced this issue May 25, 2014
This is a bunch of fixes related to #1385 (Affixes exhausting memory …
a06882f 
…and spawning threads until the nodemanager crashes):

 * The CoordinationAffix, NatDeciderAffix, and NatPunchAffix use cachedadvertise.r2py and advertisepipe.r2py instead of advertise_objects (#1387). This makes it that the continuous Affix readvertisements are done in one central place, thus saving threads; furthermore, our own announcements are immediately available in cachedadvertise. This makes lookups of keys we announce much faster.
 * Yet more speed in connection setup is gained through the new random_shuffle function (#1388) when selecting a TCP source port (#1362).
 * The Affixes and the nodemanager now raise errors with more detailed information attached (#1289).
 * The nodemanager now uses advertisepipe too to announce the node's Zenodotus name to IP address mapping. BE WARNED, node IP changes are currently NOT respected by the logic!
A final note: The NAT forwarders currently advertising under '__AFFIX_NAT_FORWARDER__' are incompatible with this release as they are using advertise_object's mangled value format. Before publishing this release, the forwarders need to be upgraded; this release must then be pushed to all existing nodes or they will not be able to contact the (then-upgraded) NAT forwarders.
If you want to test this release now and can't wait for upgraded forwarders, there is a single NAT forwarder advertising '__NAT_AFFIX_FORWARDER--post-7209__' that already uses the new format. Change the NAT_FORWARDER_ADVERTISE_KEY definition in your nat_forwarder_common_lib.repy accordingly to reach that special forwarder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaaaalbert aaaaalbert

Labels
C: seattlelib P: major T: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaaaalbert @choksi81