Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_time_tcp.py doesn't notify about clock differences between servers #10

Open
aaaaalbert opened this issue Dec 30, 2014 · 0 comments

Comments

@aaaaalbert
Copy link
Contributor

The test_time_tcp integration test checks (among other things) if the replies it gets from querying multiple time servers are within a reasonable time interval. This is implemented by comparing the difference between maximum and minimum received timestamp with the time elapsed between the first and the last server contact. The idea is that if the server clocks and local clock are progressing at the same rate, and the server clocks are set correctly, then the difference and time elapsed should be identical (up to some slack).

The current implementation fails to send notifications if the slack becomes excessive, because it references undeclared variables:

https://github.com/SeattleTestbed/integrationtests/blob/master/time/test_time_tcp.py#L88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant