Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML tags in dialog when adding exception #12

Open
rugk opened this issue Aug 10, 2016 · 3 comments
Open

HTML tags in dialog when adding exception #12

rugk opened this issue Aug 10, 2016 · 3 comments

Comments

@rugk
Copy link

rugk commented Aug 10, 2016

exception

German translation used here

@krisbr
Copy link
Contributor

krisbr commented Aug 10, 2016

Thanks for your bug report, I'll remove those tags in the next version.

@rugk
Copy link
Author

rugk commented Aug 10, 2016

What about parsing them correctly?

I mean currently this warning message is not really effective. For a user it is just a big wall of text with one button "Cancel" and one "Go on". You may be surprised how fast users can click on "Go on, now!"... 😆

This means you probably want to make the address even larger now here and maybe use a font, where the difference between different letters is clearly visible. I think fonts for programming such as Hack might be useful here.

See also https://zeltser.com/designing-security-warnings/

@krisbr
Copy link
Contributor

krisbr commented Aug 10, 2016

The add-on parsed them correctly in the last version but we removed the HTML-parsing because a reviewer told us that it might be a security issue. I thought that I removed all of the HTML-tags but apparently I was wrong.

I totally agree that it was much easier for users to decide before. I'll try to improve it in the next version as well but I can't promise anything yet. Thanks for your link, it's really interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants