Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep-link handling #224

Open
jokakilla opened this issue Mar 10, 2024 · 1 comment
Open

Deep-link handling #224

jokakilla opened this issue Mar 10, 2024 · 1 comment

Comments

@jokakilla
Copy link

jokakilla commented Mar 10, 2024

First of all thanks for the awesome app :)
I have a corner-case that isn't working as expected. I want to start an app via QR code containing a deep-link with custom schema.
See this regarding deep-links: https://developer.android.com/training/app-links/deep-linking https://medium.com/androiddevelopers/the-deep-links-crash-course-part-1-introduction-to-deep-links-2189e509e269

E.g. bm://test/bla

When scanning such custom QR codes the app always tries to open with a browser.
The reason seems to be that the code always adds "http://" in front of the deeplink. bm://test/bla -> http://bm://test/bla

When replacing (quick and dirty for testing) this line

if (!lowercase_qrurl.startsWith("http://") && !lowercase_qrurl.startsWith("https://")) {
by if(false) { so the app always ends up in else the deep-link handling is working fine in my usecase.

@jokakilla
Copy link
Author

I've created a pull request that is working for the scenarios I've tested. But it's not unlikely I've missed something.

#225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant