Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to manually select dark/light mode #109

Open
jahway603 opened this issue Dec 15, 2023 · 6 comments
Open

Add setting to manually select dark/light mode #109

jahway603 opened this issue Dec 15, 2023 · 6 comments

Comments

@jahway603
Copy link
Contributor

jahway603 commented Dec 15, 2023

Add setting to manually select dark/light mode as seen in SecUSo/privacy-friendly-qr-scanner#174

@jahway603
Copy link
Contributor Author

@udenr can you please help me implement this? I know you implemented this feature in another SecUSo app, as mentioned in the OP of this Issue. I'm having trouble figuring out how to rewrite SettingsActivity.java, but have added code from your commit here jahway603@5594b0f. Any help would be appreciated.

@udenr
Copy link
Contributor

udenr commented Feb 9, 2024

This app does not even support dark mode yet. Maybe that's the problem why it's not working for you. You first need to change the theme to one that supports dark mode and then adjust the colors. This should work similar to this commit. Then it should already follow the system settings. You might need to adjust some additional resources or code, that everything uses the new Theme as seen in this commit. I hope this helps.

@DrDustwolf
Copy link

Still the same issue. I installed some of your programms, but as there is no dark/amoled-black/night-mode availlable, I'm not very often using your tools. They're just to bright and hurt my eyes.

I've installed the following of your tools:
Version 2.3.0
org.secuso.privacyfriendlyfinancemanager

Version 1.1.1
org.secuso.privacyfriendlyruler

Version 1.1.1
org.secuso.privacyfriendlytapemeasure

Version 1.2.2
org.secuso.privacyfriendlybattleship

Version 1.3.2
org.secuso.privacyfriendlypaindiary

@jahway603
Copy link
Contributor Author

@DrDustwolf I agree that the apps without a dark theme are to bright and also hurt my eyes.

@udenr
Copy link
Contributor

udenr commented Dec 2, 2024

@jahway603 Can you create a pull request with your changes? Maybe I can take a look at it and fix it if there are only minor changes required.

@jahway603
Copy link
Contributor Author

@jahway603 Can you create a pull request with your changes? Maybe I can take a look at it and fix it if there are only minor changes required.

Just created a PR with my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants