-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve location add function #145
Comments
Thanks for your comment @Tyler-2, unfortunately we had to ditch the ZIP codes, as the newer OWM database doesn't contain them anymore. |
I didn't find the map view particularly useful. Search, for instance, for Fairfax. It seems like I'd have to click each Fairfax, see where it is on the small map, and then go back up, backspace away the autocomplete until the list comes up again, try again, repeat... It sounds like OWM doesn't even support States...
No mention of states. That's.... really rough for US users. We have a lot of city names that are common in a lot of states. The only thing I can think of if OWM can't return this data is passing the geo coords for U.S. cities into an OSM function that returns the state. |
Would a display of multiple results on the map solve this? |
Yeah, that would help. |
what about using a free geocoder API like this https://photon.komoot.io/ ? |
I played around a little with this API, maybe I am going to use it in future in RadarWeather even though it will be quite some work to adapt the app to completely work without a city ID... If you want to play with the search tool you can try this little app: https://github.com/woheller69/AutoSuggestTextViewAPICall |
I implemented it in V3.0 of RadarWeather. Works great. Once activated in settings you can find any place in the world that is in OpenStreetMap - also via ZIP code |
Another approach could (optionally) filter the results for geographic closeness to current location (if the location feature would get implemented). |
The photon API would also allow such filtering but I don't think it is necessary. It works very fast with few clicks |
In the U.S.A, most people, when prompted to enter their location, will provide their ZIP / postal code. Weather doesn't appear to support that, as entering a zip code doesn't produce anything in the dropdowns. As a fallback, I decided to enter my city... But the dropdown list provides 5 or 6 matches for my city, none specific enough. For instance: "Buena Vista, US", with lat/longs for each, because there are many states in the US with a city called Buena Vista. Most folks don't know their lat/long. It would be more typical here to say "Buena Vista, TX, US".
It would be best to get zip codes working.
But at a minimum, the state that a city is in should be shown.
The text was updated successfully, but these errors were encountered: