Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

wait_readable is not waiting - mistake in code #14

Closed
ranm opened this issue Dec 1, 2015 · 2 comments
Closed

wait_readable is not waiting - mistake in code #14

ranm opened this issue Dec 1, 2015 · 2 comments
Assignees
Labels
GPRS_Shield_Suli Label for GPRS_Shield_Suli UAY Unassigned yet

Comments

@ranm
Copy link

ranm commented Dec 1, 2015

in "sim900_wait_readable"

instead of :
while((unsigned long) (millis() - timerStart) > wait_time * 1000UL)

should be

while((unsigned long) (millis() - timerStart) < wait_time * 1000UL)

(the comparison is the wrong way so it never waits ....)

@lanselambor
Copy link
Contributor

ranm,

Thank you, the mistake has been corrected...

@ranm
Copy link
Author

ranm commented Dec 24, 2015

Hey ,
Are you merging this to the non suli project as well ?

@MatthewJeffson MatthewJeffson added UAY Unassigned yet GPRS_Shield_Suli Label for GPRS_Shield_Suli labels Oct 9, 2024
@Lesords Lesords self-assigned this Oct 15, 2024
@baorepo baorepo closed this as completed Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
GPRS_Shield_Suli Label for GPRS_Shield_Suli UAY Unassigned yet
Projects
Status: Done
Development

No branches or pull requests

5 participants