Build error against PostgreSQL 14

[devrimgunduz]

Hi,
1.4.0 fails to build also against PostgreSQL 14. Log is attached. Can you please take a look?

Regards, Devrim

multicorn-pg14.txt

[devrimgunduz]

Anyone around?

[devrimgunduz]

ping.

[fjf2002]

I'm having the same problem.

[devrimgunduz]

Anyone around ?

[fjf2002]

I have forked this repo and tried to make it compatible with PostgreSQL 14 (and Python 3.9) experimentally at https://github.com/fjf2002/Multicorn .

Disclaimer: I am not sure what I am doing. I think PostgreSQL extension experts are needed.

What I have done:

• applied the Debian bullseye pg13 patch from https://packages.debian.org/source/bullseye/postgresql-multicorn
• replaced PyUnicode_AS_DATA calls by PyUnicode_AsUTF8
• added PlannerInfo parameters to pull_varnos call and calling methods in stacktrace where possible
• as far as I understand, I have currently disabled WHERE condition pushdown(?) (this is because multicornBeginForeignScan has no reference to PlannerInfo, but pull_varnos needs it in PostgreSQL 14)
• as far as I understand, I have currently disabled data modification(?) - that's because of further compile errors due to PostgreSQL 14 changes I did not know how to solve).

[fjf2002]

Any news here?

[df7cb]

The state is still that someone needs to fix all the problems. Does your fork work now?

[fjf2002]

My fork works FOR ME. I just use SELECT to retreive some foreign tables. Please see my comment above, especially the sentences "as far as I understand ..."

[fjf2002]

https://github.com/pgsql-io/Multicorn/commits/master and #272 see to be further developed than mine (https://github.com/fjf2002/Multicorn). Take them.

[denishpatel]

@devrimgunduz @df7cb @fjf2002 is anyone able to build multicorn with Postgres 14 yet? Any pointers and help will be appreciated.

[fjf2002]

@denishpatel: Affirmative. My build code is approx.

	apt-get install -y build-essential postgresql-server-dev-14 python3-dev python3-setuptools
	# anticipating a following installation error "dir not found":
	mkdir -p /usr/share/doc/postgresql-doc-14/extension
	cd /usr/local/src/
	wget https://github.com/credativ/Multicorn/archive/refs/heads/pg14.zip
	unzip pg14.zip
	cd Multicorn-pg14
	# silence python3 complaints
	echo > preflight-check.sh
	make
	make install

[denishpatel]

@fjf2002 Thanks for the details. However, it looks like you disabled WHERE clause push down so it's not working for my case because i'm using Multicorn for BigQuery FDW. Is it easy to enable WHERE push down?

[fjf2002]

@denishpatel: Look closely at my build code. I abandoned https://github.com/fjf2002/Multicorn, instead use the https://github.com/credativ/Multicorn fork. Whether this fork can pushdown conditions I do not know.

[denishpatel]

@fjf2002 Thanks. Looks like WIP patch might have broke WHERE clause condition credativ@4bde5a1 /cc @df7cb

[luss]

In pgsql-io/multicorn, I've got the code in the master branch now compiling against PG14. Now on to testing.

[df7cb]

@fjf2002 Thanks. Looks like WIP patch might have broke WHERE clause condition credativ@4bde5a1 /cc @df7cb

It's still WIP, I never claimed it was finished...

I eventually gave up on fixing it since the project was pretty dead in general.

[luss]

pgsql-io/multicorn2 is now up to version 2.2 and is working for pg14 including WHERE pushdowns. More testing by others is needed.

[fjf2002]

@luss Thanks, I have switched to pgsql-io/multicorn2. It works - but I am just using ldap with a simple SELECT.

[cerdman]

Any updates on this ?

[luss]

My update is that Multicorn2 is alive and well at https://github.com/oscg-io/multicorn2. It builds and works with both pg13 & pg14. We incorporated pull requests from this repo for buildin with pg13 and we developed our own for building with pg14. Segfault-Inc is out of business. We are trying to carry on with the good work that they did.

…

On Sun, Aug 7, 2022 at 12:11 AM colin b. erdman ***@***.***> wrote: Any updates on this ? — Reply to this email directly, view it on GitHub <#269 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMWOHVCQX54YCLP4WVZZZLVX4ZQ5ANCNFSM46BZKJLA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[fjf2002]

@luss: Your link does not work, at least for me. Private Repo?