From 292b5d7dbcafafd2c9187419966291d744fc15a8 Mon Sep 17 00:00:00 2001 From: Tomer Date: Wed, 4 Apr 2018 14:26:27 +0300 Subject: [PATCH 1/3] added control flow commands to autocomplete --- packages/selenium-ide/src/neo/models/Command.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/selenium-ide/src/neo/models/Command.js b/packages/selenium-ide/src/neo/models/Command.js index ea83c8e910..59d928eb66 100644 --- a/packages/selenium-ide/src/neo/models/Command.js +++ b/packages/selenium-ide/src/neo/models/Command.js @@ -106,14 +106,21 @@ export const Commands = Object.freeze({ assertText: "assert text", assertTitle: "assert title", assertValue: "assert value", + break: "break", chooseCancelOnNextConfirmation: "choose cancel on next confirmation", chooseCancelOnNextPrompt: "choose cancel on next prompt", chooseOkOnNextConfirmation: "choose ok on next confirmation", clickAt: "click at", + continue: "continue", + do: "do", doubleClickAt: "double click at", dragAndDropToObject: "drag and drop to object", echo: "echo", editContent: "edit content", + else: "else", + end: "end", + endDo: "endDo", + if: "if", mouseDownAt: "mouse down at", mouseMoveAt: "mouse move at", mouseOut: "mouse out", @@ -132,6 +139,7 @@ export const Commands = Object.freeze({ storeText: "store text", storeTitle: "store title", submit: "submit", + times: "times", type: "type", verifyChecked: "verify checked", verifyNotChecked: "verify not checked", @@ -147,7 +155,8 @@ export const Commands = Object.freeze({ webdriverAnswerOnNextPrompt: "webdriver answer on next prompt", webdriverChooseCancelOnNextConfirmation: "webdriver choose cancel on next confirmation", webdriverChooseCancelOnNextPrompt: "webdriver choose cancel on next prompt", - webdriverChooseOkOnNextConfirmation: "webdriver choose ok on next confirmation" + webdriverChooseOkOnNextConfirmation: "webdriver choose ok on next confirmation", + while: "while" }); export const CommandsArray = Object.freeze(Object.keys(Commands)); From b96ed99155ffae5555e59eaf087c65d1319bdcd4 Mon Sep 17 00:00:00 2001 From: Tomer Date: Wed, 4 Apr 2018 14:48:46 +0300 Subject: [PATCH 2/3] indentation --- packages/selenium-ide/src/neo/components/TestRow/index.jsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/selenium-ide/src/neo/components/TestRow/index.jsx b/packages/selenium-ide/src/neo/components/TestRow/index.jsx index c09933eb93..a3ff29a7c6 100644 --- a/packages/selenium-ide/src/neo/components/TestRow/index.jsx +++ b/packages/selenium-ide/src/neo/components/TestRow/index.jsx @@ -106,6 +106,7 @@ class TestRow extends React.Component { command: PropTypes.string.isRequired, target: PropTypes.string, value: PropTypes.string, + level: PropTypes.number, isBreakpoint: PropTypes.bool, toggleBreakpoint: PropTypes.func, onClick: PropTypes.func, @@ -200,6 +201,7 @@ class TestRow extends React.Component { //setting component of context menu. this.props.setContextMenu(listMenu); + const index = this.props.index >= 0 ? {this.props.index + 1}. : null; const rendered = {return(this.node = node || this.node);}} className={classNames(this.props.className, {"selected": this.props.selected}, {"break-point": this.props.isBreakpoint}, {"dragging": this.props.dragInProgress})} @@ -214,12 +216,12 @@ class TestRow extends React.Component { }}> {this.props.comment ? - {this.props.index >= 0 ? {this.props.index + 1}. : null} + {index} {this.props.comment} : - {this.props.index >= 0 ? {this.props.index + 1}. : null} + {index} {this.props.command} {this.props.target} From a901f3efa2eee5e218dba8546f3e447f39e42164 Mon Sep 17 00:00:00 2001 From: Tomer Date: Wed, 4 Apr 2018 16:43:58 +0300 Subject: [PATCH 3/3] indent the commands in the table --- .../src/neo/components/TestTable/index.jsx | 37 +++++++++++++++++-- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/packages/selenium-ide/src/neo/components/TestTable/index.jsx b/packages/selenium-ide/src/neo/components/TestTable/index.jsx index ea905b026b..8762cfcd64 100644 --- a/packages/selenium-ide/src/neo/components/TestTable/index.jsx +++ b/packages/selenium-ide/src/neo/components/TestTable/index.jsx @@ -40,6 +40,7 @@ export default class TestTable extends React.Component { clearAllCommands: PropTypes.func }; render() { + let level = 0; return ([
@@ -55,8 +56,9 @@ export default class TestTable extends React.Component {
- { this.props.commands ? this.props.commands.map((command, index) => ( - { + if (isBlockEnd(command.command) && level > 0) level--; + const row = { UiState.copyToClipboard(command); }} clearAllCommands={this.props.clearAllCommands} setSectionFocus={UiState.setSectionFocus} - /> - )).concat( + />; + if (isBlock(command.command)) level++; + return row; + }).concat(