Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datatables] render text formatting #849

Open
D-Groenewegen opened this issue Sep 24, 2024 · 0 comments
Open

[datatables] render text formatting #849

D-Groenewegen opened this issue Sep 24, 2024 · 0 comments

Comments

@D-Groenewegen
Copy link
Contributor

Setup

  • MW version: 1.39
  • SMW version: 4.1.3
  • SRF version: 4.2.0

First of all, many thanks for putting in all the hard work in not only re-implementing this format but providing a new version that can do so much more. So much, in fact, that I have yet to explore its full potential. Thumbs up!

Issue

If the new Datatables format is going to supersede SMW's implementation of it through the datatable class, I think there is at least one issue that need to be addressed first. Currently, the new Datatables format exposes all HTML tags for italics, subscripts/superscripts and the like, while the SMW version handles them correctly. The SMW version isn't perfect either because it does not support wikitext conversion to HTML.

That means there are two steps to fixing this:

  1. Support wikitext conversion to HTML
  2. Run html_entity_decode on the results from the query printer where the returned value is one of a property of type Text (or String).
    • The page links are rendered fine, by the way, because the link tags don't have their characters replaced by html entities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant