Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single column mui #1520

Merged
merged 17 commits into from
Oct 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const useStyles = makeStyles(() => {
position: 'relative',
},
field: {
width: '75%',
width: '88%',
position: 'relative',
},
fieldFullWidth: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export const AllowedChildTypes: React.FC<ReactClientFieldSetting & { classes?: A
case 'new':
return (
<ClickAwayListener onClickAway={handleClickAway}>
<div>
<div style={{ display: 'inline-block', minWidth: '350px' }}>
<InputLabel shrink htmlFor={props.settings.Name} required={props.settings.Compulsory}>
{props.settings.DisplayName}
</InputLabel>
Expand Down Expand Up @@ -264,7 +264,6 @@ export const AllowedChildTypes: React.FC<ReactClientFieldSetting & { classes?: A
onClick={handleOnClick}
onChange={handleInputChange}
placeholder={INPUT_PLACEHOLDER}
fullWidth={true}
value={inputValue}
className={classes.input}
/>
Expand Down
6 changes: 2 additions & 4 deletions packages/sn-controls-react/src/fieldcontrols/date-picker.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,8 @@ export const DatePicker: React.FC<ReactClientFieldSetting<DateTimeFieldSetting>>
label={settings.DisplayName}
id={settings.Name}
disabled={settings.ReadOnly}
placeholder={settings.DisplayName}
InputLabelProps={{ shrink: true }}
required={settings.Compulsory}
fullWidth={true}
format="yyyy MMMM dd"
/>
) : (
Expand All @@ -109,9 +108,8 @@ export const DatePicker: React.FC<ReactClientFieldSetting<DateTimeFieldSetting>>
name={settings.Name}
id={settings.Name}
disabled={settings.ReadOnly}
placeholder={settings.DisplayName}
InputLabelProps={{ shrink: true }}
required={settings.Compulsory}
fullWidth={true}
format="yyyy MMMM dd hh:mm aaaa"
/>
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ export const DropDownList: React.FC<ReactClientFieldSetting<ChoiceFieldSetting>>
case 'edit':
case 'new':
return (
<FormControl fullWidth={true} required={props.settings.Compulsory} disabled={props.settings.ReadOnly}>
<FormControl
style={{ minWidth: '220px' }}
required={props.settings.Compulsory}
disabled={props.settings.ReadOnly}>
<InputLabel htmlFor={props.settings.Name}>{props.settings.DisplayName}</InputLabel>
<Select
onChange={handleChange}
Expand Down
4 changes: 2 additions & 2 deletions packages/sn-controls-react/src/fieldcontrols/number.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ export const NumberField: React.FC<ReactClientFieldSetting<NumberFieldSetting |
value={value}
required={props.settings.Compulsory}
disabled={props.settings.ReadOnly}
placeholder={props.settings.DisplayName}
placeholder="0"
InputLabelProps={{ shrink: true }}
InputProps={{
startAdornment: defineCurrency(),
endAdornment: props.settings.ShowAsPercentage ? <InputAdornment position="end">%</InputAdornment> : null,
Expand All @@ -76,7 +77,6 @@ export const NumberField: React.FC<ReactClientFieldSetting<NumberFieldSetting |
min: props.settings.MinValue,
}}
id={props.settings.Name}
fullWidth={true}
onChange={handleChange}
/>
{!props.hideDescription && <FormHelperText>{props.settings.Description}</FormHelperText>}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,9 @@ export const DefaultItemTemplate: React.FC<DefaultItemTemplateProps> = (props) =
}

return (
<ListItem key={content.Id} button={false}>
<ListItem style={props.actionName === 'browse' ? { padding: 0 } : undefined} key={content.Id} button={false}>
{content.Type ? renderIcon(content) : null}
<ListItemText
primary={content.DisplayName}
style={content.Id < 0 ? { textAlign: 'right', paddingRight: 16 } : { textAlign: 'left' }}
/>
<ListItemText primary={content.DisplayName} style={{ textAlign: 'left', paddingRight: 15 }} />
{props.actionName && props.actionName !== 'browse' && !props.readOnly ? (
<ListItemSecondaryAction>
{content.Id > 0 ? (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,13 @@ const styles = {
root: {
display: 'flex',
flexWrap: 'wrap',
alignItems: 'flex-start',
},
listContainer: {
display: 'block',
marginTop: 10,
display: 'inline-block',
minWidth: 250,
padding: 0,
marginTop: 15,
},
}

Expand Down Expand Up @@ -232,9 +235,9 @@ export const ReferenceGrid: React.FC<ReferenceGridProps> = (props) => {
default: {
return (
<FormControl style={styles.root as any}>
<InputLabel shrink={true} htmlFor={props.settings.Name}>
<Typography variant="caption" gutterBottom={true}>
{props.settings.DisplayName}
</InputLabel>
</Typography>
<FormGroup>
{fieldValue ? (
<List dense={true} style={styles.listContainer}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export const ShortText: React.FC<ReactClientFieldSetting<ShortTextFieldSetting>>
name={props.settings.Name}
id={props.settings.Name}
label={props.settings.DisplayName}
placeholder={props.settings.DisplayName}
InputLabelProps={{ shrink: true }}
value={value}
required={props.settings.Compulsory}
disabled={props.settings.ReadOnly}
Expand Down
2 changes: 1 addition & 1 deletion packages/sn-controls-react/src/fieldcontrols/switcher.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ const useStyles = makeStyles(() =>
alignItems: 'flex-start',
},
alignedCenter: {
alignItems: 'center',
alignItems: 'flex-start',
},
}),
)
Expand Down
6 changes: 3 additions & 3 deletions packages/sn-controls-react/src/viewcontrols/browse-view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ export const BrowseView: React.FC<BrowseViewProps> = (props) => {
item={true}
xs={12}
sm={12}
md={isFullWidth ? 12 : 6}
lg={isFullWidth ? 12 : 6}
xl={isFullWidth ? 12 : 6}
md={12}
lg={12}
xl={12}
key={field.fieldSettings.Name}
className={classes.fieldWrapper}>
<div className={isFullWidth ? classes.fieldFullWidth : classes.field}>
Expand Down
6 changes: 3 additions & 3 deletions packages/sn-controls-react/src/viewcontrols/edit-view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@ export const EditView: React.FC<EditViewProps> = (props) => {
item={true}
xs={12}
sm={12}
md={isFullWidth ? 12 : 6}
lg={isFullWidth ? 12 : 6}
xl={isFullWidth ? 12 : 6}
md={12}
lg={12}
xl={12}
key={field.fieldSettings.Name}
className={classes.fieldWrapper}>
<div className={isFullWidth ? classes.fieldFullWidth : classes.field}>{fieldControl}</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,15 @@ exports[`Date/Date time field control in edit/new view should set all the props
utils={[Function]}
>
<PickerWithState
InputLabelProps={
Object {
"shrink": true,
}
}
allowKeyboardControl={true}
ampm={true}
disabled={true}
format="yyyy MMMM dd hh:mm aaaa"
fullWidth={true}
id="ModificationDate"
invalidDateMessage="Invalid Date Format"
label="Modification Date"
Expand All @@ -42,7 +46,6 @@ exports[`Date/Date time field control in edit/new view should set all the props
onChange={[Function]}
openTo="date"
orientation="portrait"
placeholder="Modification Date"
required={true}
showTabs={true}
value="1912-04-15T02:10:00.000Z"
Expand All @@ -67,10 +70,14 @@ exports[`Date/Date time field control in edit/new view should set all the props
utils={[Function]}
>
<PickerWithState
InputLabelProps={
Object {
"shrink": true,
}
}
allowKeyboardControl={true}
disabled={true}
format="yyyy MMMM dd"
fullWidth={true}
id="ModificationDate"
invalidDateMessage="Invalid Date Format"
label="Modification Date"
Expand All @@ -81,7 +88,6 @@ exports[`Date/Date time field control in edit/new view should set all the props
name="ModificationDate"
onChange={[Function]}
openTo="date"
placeholder="Modification Date"
required={true}
value="1912-04-15T02:10:00.000Z"
views={
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,12 @@
exports[`Drop down list field control in edit/new view should set all the props 1`] = `
<WithStyles(ForwardRef(FormControl))
disabled={true}
fullWidth={true}
required={true}
style={
Object {
"minWidth": "220px",
}
}
>
<WithStyles(ForwardRef(InputLabel))
htmlFor="VersioningMode"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ exports[`Number field control in browse view should show the displayname and fie
exports[`Number field control in edit/new view should set all the props 1`] = `
<Fragment>
<WithStyles(ForwardRef(TextField))
InputLabelProps={
Object {
"shrink": true,
}
}
InputProps={
Object {
"endAdornment": <WithStyles(ForwardRef(InputAdornment))
Expand All @@ -35,7 +40,6 @@ exports[`Number field control in edit/new view should set all the props 1`] = `
}
}
disabled={true}
fullWidth={true}
id="Index"
inputProps={
Object {
Expand All @@ -47,7 +51,7 @@ exports[`Number field control in edit/new view should set all the props 1`] = `
label="Index"
name="Index"
onChange={[Function]}
placeholder="Index"
placeholder="0"
required={true}
type="number"
value={7}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ exports[`Short text field control in browse view should show the displayname and
exports[`Short text field control in edit/new view should set all the props 1`] = `
<Fragment>
<WithStyles(ForwardRef(TextField))
InputLabelProps={
Object {
"shrink": true,
}
}
autoComplete="off"
disabled={true}
fullWidth={true}
Expand All @@ -34,7 +39,6 @@ exports[`Short text field control in edit/new view should set all the props 1`]
label="Display name"
name="DisplayName"
onChange={[Function]}
placeholder="Display name"
required={true}
value="Hello World"
/>
Expand Down
2 changes: 0 additions & 2 deletions packages/sn-controls-react/test/date-picker.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ describe('Date/Date time field control', () => {
expect(wrapper.find(DateTimePicker).prop('name')).toBe(defaultSettings.Name)
expect(wrapper.find(DateTimePicker).prop('id')).toBe(defaultSettings.Name)
expect(wrapper.find(DateTimePicker).prop('label')).toBe(defaultSettings.DisplayName)
expect(wrapper.find(DateTimePicker).prop('placeholder')).toBe(defaultSettings.DisplayName)
expect(wrapper.find(DateTimePicker).prop('required')).toBeTruthy()
expect(wrapper.find(DateTimePicker).prop('disabled')).toBeTruthy()
expect(wrapper).toMatchSnapshot()
Expand Down Expand Up @@ -109,7 +108,6 @@ describe('Date/Date time field control', () => {
expect(wrapper.find(MUIDatePicker).prop('name')).toBe(defaultSettings.Name)
expect(wrapper.find(MUIDatePicker).prop('id')).toBe(defaultSettings.Name)
expect(wrapper.find(MUIDatePicker).prop('label')).toBe(defaultSettings.DisplayName)
expect(wrapper.find(MUIDatePicker).prop('placeholder')).toBe(defaultSettings.DisplayName)
expect(wrapper.find(MUIDatePicker).prop('required')).toBeTruthy()
expect(wrapper.find(MUIDatePicker).prop('disabled')).toBeTruthy()
expect(wrapper).toMatchSnapshot()
Expand Down
2 changes: 1 addition & 1 deletion packages/sn-controls-react/test/number.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe('Number field control', () => {
expect(wrapper.find(TextField).prop('name')).toBe(defaultSettings.Name)
expect(wrapper.find(TextField).prop('id')).toBe(defaultSettings.Name)
expect(wrapper.find(TextField).prop('label')).toBe(defaultSettings.DisplayName)
expect(wrapper.find(TextField).prop('placeholder')).toBe(defaultSettings.DisplayName)
expect(wrapper.find(TextField).prop('placeholder')).toBe('0')
expect(wrapper.find(TextField).prop('required')).toBeTruthy()
expect(wrapper.find(TextField).prop('disabled')).toBeTruthy()
expect(wrapper.find(FormHelperText).text()).toBe(defaultSettings.Description)
Expand Down
10 changes: 7 additions & 3 deletions packages/sn-controls-react/test/reference-grid.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,16 @@ describe('Reference grid field control', () => {
describe('in browse view', () => {
it('should show no value message when field value is not provided', () => {
const wrapper = shallow(<ReferenceGrid actionName="browse" settings={defaultSettings} />)
expect(wrapper.find(Typography).text()).toBe(defaultLocalization.referenceGrid.noValue)
expect(wrapper.find(Typography).filter({ variant: 'body1' }).text()).toBe(
defaultLocalization.referenceGrid.noValue,
)
})

it('should show no value message when field value is empty array', () => {
const wrapper = shallow(<ReferenceGrid actionName="browse" settings={defaultSettings} fieldValue={[] as any} />)
expect(wrapper.find(Typography).text()).toBe(defaultLocalization.referenceGrid.noValue)
expect(wrapper.find(Typography).filter({ variant: 'body1' }).text()).toBe(
defaultLocalization.referenceGrid.noValue,
)
})

it('should render the default item template when there is a field value', async () => {
Expand All @@ -102,7 +106,7 @@ describe('Reference grid field control', () => {
})

expect(wrapper.find(DefaultItemTemplate)).toHaveLength(1)
expect(wrapper.find(InputLabel).text()).toBe(defaultSettings.DisplayName)
expect(wrapper.find(Typography).filter({ variant: 'caption' }).text()).toBe(defaultSettings.DisplayName)
})

it('should create an allowed type list filter', async () => {
Expand Down
1 change: 0 additions & 1 deletion packages/sn-controls-react/test/short-text.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ describe('Short text field control', () => {
expect(wrapper.find(TextField).prop('name')).toBe(defaultSettings.Name)
expect(wrapper.find(TextField).prop('id')).toBe(defaultSettings.Name)
expect(wrapper.find(TextField).prop('label')).toBe(defaultSettings.DisplayName)
expect(wrapper.find(TextField).prop('placeholder')).toBe(defaultSettings.DisplayName)
expect(wrapper.find(TextField).prop('required')).toBeTruthy()
expect(wrapper.find(TextField).prop('disabled')).toBeTruthy()
expect(wrapper.find(FormHelperText).text()).toEqual('description')
Expand Down
Loading