From d39986123246b461b9b78186f851dc3c3f71b31b Mon Sep 17 00:00:00 2001 From: Phill Kelley <34226495+Paraphraser@users.noreply.github.com> Date: Tue, 2 Apr 2024 16:20:27 +1100 Subject: [PATCH] 2024-04-02 missing port-mapping quotes - master branch - PR 1 of 2 Following on from discussion in #761, this adds quotes to port mappings as recommended in docker-compose [documentation](https://docs.docker.com/compose/compose-file/05-services/#short-syntax-3): > HOST:CONTAINER should always be specified as a (quoted) string, to avoid conflicts with [yaml base-60 float](https://yaml.org/type/float.html) Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com> --- .templates/dashmachine/service.yml | 2 +- .templates/heimdall/service.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.templates/dashmachine/service.yml b/.templates/dashmachine/service.yml index 6ae12ee6d..20ed3c35e 100644 --- a/.templates/dashmachine/service.yml +++ b/.templates/dashmachine/service.yml @@ -4,6 +4,6 @@ dashmachine: volumes: - ./volumes/dashmachine/user_data:/dashmachine/dashmachine/user_data ports: - - 5000:5000 + - "5000:5000" restart: unless-stopped diff --git a/.templates/heimdall/service.yml b/.templates/heimdall/service.yml index bd8619b86..a5dad453b 100644 --- a/.templates/heimdall/service.yml +++ b/.templates/heimdall/service.yml @@ -8,7 +8,7 @@ heimdall: volumes: - ./volumes/heimdall/config:/config ports: - - 8882:80 - - 8883:443 + - "8882:80" + - "8883:443" restart: unless-stopped